Skip to content

Commit 13364af

Browse files
committed
change test naming
1 parent d5ba31e commit 13364af

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

packages/vue/test/tracing/tracingMixin.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('Vue Tracing Mixins', () => {
114114
});
115115

116116
describe('Root Component Behavior', () => {
117-
it('should always create a span for the Vue root component regardless of tracking options', () => {
117+
it('should always create a root component span for the Vue root component regardless of tracking options', () => {
118118
const mixins = createTracingMixins({ trackComponents: false });
119119

120120
mixins.beforeMount.call(mockRootInstance);
@@ -127,8 +127,8 @@ describe('Vue Tracing Mixins', () => {
127127
);
128128
});
129129

130-
it('should finish root span on timer after component spans end', () => {
131-
// todo/fixme: This root span is only finished if trackComponents is true --> it should probably be always finished
130+
it('should finish root component span on timer after component spans end', () => {
131+
// todo/fixme: This root component span is only finished if trackComponents is true --> it should probably be always finished
132132
const mixins = createTracingMixins({ trackComponents: true, timeout: 1000 });
133133
const rootMockSpan = mockSpanFactory();
134134
mockRootInstance.$_sentryRootSpan = rootMockSpan;
@@ -137,10 +137,10 @@ describe('Vue Tracing Mixins', () => {
137137
mixins.beforeMount.call(mockVueInstance);
138138
mixins.mounted.call(mockVueInstance);
139139

140-
// Root span should not end immediately
140+
// Root component span should not end immediately
141141
expect(rootMockSpan.end).not.toHaveBeenCalled();
142142

143-
// After timeout, root span should end
143+
// After timeout, root component span should end
144144
vi.advanceTimersByTime(1001);
145145
expect(rootMockSpan.end).toHaveBeenCalled();
146146
});
@@ -192,7 +192,7 @@ describe('Vue Tracing Mixins', () => {
192192
expect(() => mixins.mounted.call(mockVueInstance)).not.toThrow();
193193
});
194194

195-
it('should skip spans when no active root span (transaction) exists', () => {
195+
it('should skip spans when no active root component span (transaction) exists', () => {
196196
const mixins = createTracingMixins({ trackComponents: true });
197197

198198
// Remove active spans

0 commit comments

Comments
 (0)