Skip to content

Commit 13b1897

Browse files
authored
test(e2e): Update node version used for e2e tests (#12031)
Extracted this out from #12020 For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a `.mjs` file directly - works just as well!
1 parent 733ae1d commit 13b1897

File tree

76 files changed

+62
-6356
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+62
-6356
lines changed

dev-packages/e2e-tests/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ tmp
33
.tmp_build_stdout
44
.tmp_build_stderr
55
pnpm-lock.yaml
6+
.last-run.json

dev-packages/e2e-tests/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"test:prepare": "ts-node prepare.ts",
1515
"test:validate": "run-s test:validate-configuration test:validate-test-app-setups",
1616
"clean": "rimraf tmp node_modules pnpm-lock.yaml && yarn clean:test-applications",
17-
"clean:test-applications": "rimraf test-applications/**/{node_modules,dist,build,.next,.sveltekit,pnpm-lock.yaml}"
17+
"clean:test-applications": "rimraf test-applications/**/{node_modules,dist,build,.next,.sveltekit,pnpm-lock.yaml} .last-run.json"
1818
},
1919
"devDependencies": {
2020
"@types/glob": "8.0.0",
@@ -27,8 +27,8 @@
2727
"yaml": "2.2.2"
2828
},
2929
"volta": {
30-
"node": "18.18.0",
31-
"yarn": "1.22.19",
32-
"pnpm": "8.15.5"
30+
"node": "18.20.2",
31+
"yarn": "1.22.22",
32+
"pnpm": "8.15.8"
3333
}
3434
}

dev-packages/e2e-tests/run.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ async function run(): Promise<void> {
5555
console.log('Cleaning test-applications...');
5656
console.log('');
5757

58-
registrySetup();
58+
if (!process.env.SKIP_REGISTRY) {
59+
registrySetup();
60+
}
5961

6062
await asyncExec('pnpm clean:test-applications', { env, cwd: __dirname });
6163

dev-packages/e2e-tests/test-applications/angular-17/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"scripts": {
55
"ng": "ng",
66
"dev": "ng serve",
7-
"proxy": "ts-node-script start-event-proxy.ts",
7+
"proxy": "node start-event-proxy.mjs",
88
"preview": "http-server dist/angular-17/browser --port 8080",
99
"build": "ng build",
1010
"watch": "ng build --watch --configuration development",
@@ -42,7 +42,6 @@
4242
"karma-coverage": "~2.2.0",
4343
"karma-jasmine": "~5.1.0",
4444
"karma-jasmine-html-reporter": "~2.1.0",
45-
"ts-node": "10.9.1",
4645
"typescript": "~5.3.2",
4746
"wait-port": "1.0.4"
4847
},

dev-packages/e2e-tests/test-applications/angular-17/playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const config: PlaywrightTestConfig = {
6161
/* Run your local dev server before starting the tests */
6262
webServer: [
6363
{
64-
command: 'pnpm ts-node-script start-event-proxy.ts',
64+
command: 'node start-event-proxy.mjs',
6565
port: eventProxyPort,
6666
},
6767
{

dev-packages/e2e-tests/test-applications/angular-17/tsconfig.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,5 @@
2929
"strictInjectionParameters": true,
3030
"strictInputAccessModifiers": true,
3131
"strictTemplates": true
32-
},
33-
"ts-node": {
34-
"compilerOptions": {
35-
"module": "CommonJS"
36-
}
3732
}
3833
}

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@
4646
"eslint-plugin-react-hooks": "^4.6.0",
4747
"typescript": "^5.1.6",
4848
"vite": "^5.1.0",
49-
"vite-tsconfig-paths": "^4.2.1",
50-
"ts-node": "10.9.1"
49+
"vite-tsconfig-paths": "^4.2.1"
5150
},
5251
"volta": {
5352
"extends": "../../package.json"

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const config: PlaywrightTestConfig = {
5353
/* Run your local dev server before starting the tests */
5454
webServer: [
5555
{
56-
command: 'pnpm ts-node --project="tsconfig.event-proxy-server.json" ./start-event-proxy.ts',
56+
command: 'node start-event-proxy.mjs',
5757
port: eventProxyPort,
5858
},
5959
{

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/start-event-proxy.ts renamed to dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/start-event-proxy.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { startEventProxyServer } from '@sentry-internal/event-proxy-server';
2+
23
startEventProxyServer({
34
port: 3031,
45
proxyServerName: 'create-remix-app-express-vite-dev',

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/tsconfig.event-proxy-server.json

Lines changed: 0 additions & 13 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"include": ["env.d.ts", "**/*.ts", "**/*.tsx"],
3-
"exclude": ["event-proxy-server.ts", "start-event-proxy.ts"],
43
"compilerOptions": {
54
"lib": ["DOM", "DOM.Iterable", "ES2022"],
65
"isolatedModules": true,

0 commit comments

Comments
 (0)