Skip to content

Commit 166e3cd

Browse files
committed
lint
1 parent f6cab6a commit 166e3cd

File tree

3 files changed

+27
-28
lines changed
  • dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay
  • packages/feedback/src/widget

3 files changed

+27
-28
lines changed

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/hasSampling/test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ sentryTest('should capture feedback (@sentry-internal/feedback import)', async (
3636

3737
const url = await getLocalTestPath({ testDir: __dirname });
3838

39-
await Promise.all([
40-
page.goto(url),
41-
page.getByText('Report a Bug').click(),
42-
]);
39+
await Promise.all([page.goto(url), page.getByText('Report a Bug').click()]);
4340

4441
await page.locator('[name="name"]').fill('Jane Doe');
4542
await page.locator('[name="email"]').fill('[email protected]');
Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,30 @@
11
import { expect } from '@playwright/test';
22

33
import { sentryTest } from '../../../../utils/fixtures';
4-
import { envelopeRequestParser, getEnvelopeType } from '../../../../utils/helpers';
5-
import { getCustomRecordingEvents, getReplayEvent, waitForReplayRequest } from '../../../../utils/replayHelpers';
4+
import { getReplayEvent, waitForReplayRequest } from '../../../../utils/replayHelpers';
65

7-
sentryTest('should capture feedback with no replay sampling when Form opens (@sentry-internal/feedback import)', async ({ getLocalTestPath, page }) => {
8-
if (process.env.PW_BUNDLE) {
9-
sentryTest.skip();
10-
}
6+
sentryTest(
7+
'should capture feedback with no replay sampling when Form opens (@sentry-internal/feedback import)',
8+
async ({ getLocalTestPath, page }) => {
9+
if (process.env.PW_BUNDLE) {
10+
sentryTest.skip();
11+
}
1112

12-
const reqPromise0 = waitForReplayRequest(page, 0);
13-
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
14-
return route.fulfill({
15-
status: 200,
16-
contentType: 'application/json',
17-
body: JSON.stringify({ id: 'test-id' }),
13+
const reqPromise0 = waitForReplayRequest(page, 0);
14+
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
15+
return route.fulfill({
16+
status: 200,
17+
contentType: 'application/json',
18+
body: JSON.stringify({ id: 'test-id' }),
19+
});
1820
});
19-
});
2021

21-
const url = await getLocalTestPath({ testDir: __dirname });
22+
const url = await getLocalTestPath({ testDir: __dirname });
2223

23-
const [,,replayReq] = await Promise.all([page.goto(url), page.getByText('Report a Bug').click(), reqPromise0]);
24+
const [, , replayReq] = await Promise.all([page.goto(url), page.getByText('Report a Bug').click(), reqPromise0]);
2425

25-
const replayEvent = getReplayEvent(replayReq);
26-
expect(replayEvent.segment_id).toBe(0);
27-
expect(replayEvent.replay_type).toBe('buffer');
28-
});
26+
const replayEvent = getReplayEvent(replayReq);
27+
expect(replayEvent.segment_id).toBe(0);
28+
expect(replayEvent.replay_type).toBe('buffer');
29+
},
30+
);

packages/feedback/src/widget/createWidget.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export function createWidget({
129129
/**
130130
* Internal handler when dialog is opened
131131
*/
132-
function handleOpenDialog({includeReplay}: {includeReplay?: boolean} = {}) {
132+
function handleOpenDialog({ includeReplay }: { includeReplay?: boolean } = {}) {
133133
// Flush replay if it exists
134134
if (includeReplay) {
135135
const client = getClient();
@@ -138,8 +138,8 @@ export function createWidget({
138138
return;
139139
}
140140
try {
141-
// @ts-expect-error Not sure how best to type this w/o
142-
// making @sentry/replay a dep
141+
// @ts-expect-error Not sure how best to type this w/o
142+
// making @sentry/replay a dep
143143
void replay.flush();
144144
} catch (err) {
145145
DEBUG_BUILD && logger.error(err);
@@ -179,7 +179,7 @@ export function createWidget({
179179
if (options.onFormOpen) {
180180
options.onFormOpen();
181181
}
182-
handleOpenDialog({includeReplay: options.includeReplay});
182+
handleOpenDialog({ includeReplay: options.includeReplay });
183183
return;
184184
}
185185

@@ -232,7 +232,7 @@ export function createWidget({
232232
if (options.onFormOpen) {
233233
options.onFormOpen();
234234
}
235-
handleOpenDialog({includeReplay: options.includeReplay});
235+
handleOpenDialog({ includeReplay: options.includeReplay });
236236
} catch (err) {
237237
// TODO: Error handling?
238238
logger.error(err);

0 commit comments

Comments
 (0)