Skip to content

Commit 17ee6c6

Browse files
committed
remove RTR, adjust required_jobs_passed
1 parent ffb6e64 commit 17ee6c6

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -855,8 +855,8 @@ jobs:
855855
timeout-minutes: 5
856856
run: yarn test:assert
857857

858-
job_required_tests:
859-
name: All required tests passed or skipped
858+
job_required_jobs_passed:
859+
name: All required jobs passed or were skipped
860860
needs:
861861
[
862862
job_build,
@@ -870,6 +870,9 @@ jobs:
870870
job_browser_loader_tests,
871871
job_remix_integration_tests,
872872
job_e2e_tests,
873+
job_artifacts,
874+
job_lint,
875+
job_circular_dep_check,
873876
]
874877
# Always run this, even if a dependent job failed
875878
if: always()
@@ -921,14 +924,3 @@ jobs:
921924
with:
922925
name: ${{ steps.process.outputs.artifactName }}
923926
path: ${{ steps.process.outputs.artifactPath }}
924-
925-
job_ready_to_release:
926-
name: Ready to release
927-
needs: [job_required_tests, job_artifacts, job_size_check, job_lint, job_circular_dep_check]
928-
if: needs.job_get_metadata.outputs.is_release == 'true'
929-
runs-on: ubuntu-20.04
930-
steps:
931-
- name: Check for failures
932-
if: contains(needs.*.result, 'failure')
933-
run: |
934-
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1

0 commit comments

Comments
 (0)