Skip to content

Commit 1a6c054

Browse files
committed
Rename arrayMerge to objectMerge
lol, this doesn’t even merge an array
1 parent 37ad863 commit 1a6c054

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/raven.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ var Raven = {
261261
captureMessage: function(msg, options) {
262262
// Fire away!
263263
send(
264-
arrayMerge({
264+
objectMerge({
265265
message: msg
266266
}, options)
267267
);
@@ -532,7 +532,7 @@ function processException(type, message, fileurl, lineno, frames, options) {
532532

533533
// Fire away!
534534
send(
535-
arrayMerge({
535+
objectMerge({
536536
// sentry.interfaces.Exception
537537
exception: {
538538
type: type,
@@ -546,14 +546,14 @@ function processException(type, message, fileurl, lineno, frames, options) {
546546
);
547547
}
548548

549-
function arrayMerge(arr1, arr2) {
550-
if (!arr2) {
551-
return arr1;
549+
function objectMerge(obj1, obj2) {
550+
if (!obj2) {
551+
return obj1;
552552
}
553-
each(arr2, function(key, value){
554-
arr1[key] = value;
553+
each(obj2, function(key, value){
554+
obj1[key] = value;
555555
});
556-
return arr1;
556+
return obj1;
557557
}
558558

559559
function getHttpData() {
@@ -574,7 +574,7 @@ function getHttpData() {
574574
function send(data) {
575575
if (!isSetup()) return;
576576

577-
data = arrayMerge({
577+
data = objectMerge({
578578
project: globalProject,
579579
logger: globalOptions.logger,
580580
site: globalOptions.site,
@@ -583,9 +583,9 @@ function send(data) {
583583
request: getHttpData()
584584
}, data);
585585

586-
// Merge in the tags and extra separately since arrayMerge doesn't handle a deep merge
587-
data.tags = arrayMerge(globalOptions.tags, data.tags);
588-
data.extra = arrayMerge(globalOptions.extra, data.extra);
586+
// Merge in the tags and extra separately since objectMerge doesn't handle a deep merge
587+
data.tags = objectMerge(globalOptions.tags, data.tags);
588+
data.extra = objectMerge(globalOptions.extra, data.extra);
589589

590590
// If there are no tags/extra, strip the key from the payload alltogther.
591591
if (isEmptyObject(data.tags)) delete data.tags;

test/raven.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,11 @@ describe('globals', function() {
109109
});
110110
});
111111

112-
describe('arrayMerge', function() {
112+
describe('objectMerge', function() {
113113
it('should work as advertised', function() {
114-
assert.deepEqual(arrayMerge({}, {}), {});
115-
assert.deepEqual(arrayMerge({a:1}, {b:2}), {a:1, b:2});
116-
assert.deepEqual(arrayMerge({a:1}), {a:1});
114+
assert.deepEqual(objectMerge({}, {}), {});
115+
assert.deepEqual(objectMerge({a:1}, {b:2}), {a:1, b:2});
116+
assert.deepEqual(objectMerge({a:1}), {a:1});
117117
});
118118
});
119119

0 commit comments

Comments
 (0)