fix flaky tests...?

Author: mydea

packages/browser-integration-tests/scripts/detectFlakyTests.ts

@@ -1,7 +1,6 @@
 import * as glob from 'glob';
 import * as path from 'path';
 import * as childProcess from 'child_process';
-import { promisify } from 'util';
 
 async function run(): Promise<void> {
   let testPaths: string[] = [];

packages/browser-integration-tests/suites/replay/largeMutations/defaultOptions/test.ts

@@ -28,14 +28,32 @@ sentryTest(
     const [res0] = await Promise.all([waitForReplayRequest(page, 0), gotoPageAndClick()]);
     await forceFlushReplay();
 
-    const [res1] = await Promise.all([waitForReplayRequest(page), page.click('#button-add')]);
-    await forceFlushReplay();
+    const [res1] = await Promise.all([
+      waitForReplayRequest(page, (_event, res) => {
+        const parsed = getReplayRecordingContent(res);
+        return !!parsed.incrementalSnapshots.length || !!parsed.fullSnapshots.length;
+      }),
+      page.click('#button-add'),
+      forceFlushReplay(),
+    ]);
 
-    const [res2] = await Promise.all([waitForReplayRequest(page), page.click('#button-modify')]);
-    await forceFlushReplay();
+    const [res2] = await Promise.all([
+      waitForReplayRequest(page, (_event, res) => {
+        const parsed = getReplayRecordingContent(res);
+        return !!parsed.incrementalSnapshots.length || !!parsed.fullSnapshots.length;
+      }),
+      page.click('#button-modify'),
+      forceFlushReplay(),
+    ]);
 
-    const [res3] = await Promise.all([waitForReplayRequest(page), page.click('#button-remove')]);
-    await forceFlushReplay();
+    const [res3] = await Promise.all([
+      waitForReplayRequest(page, (_event, res) => {
+        const parsed = getReplayRecordingContent(res);
+        return !!parsed.incrementalSnapshots.length || !!parsed.fullSnapshots.length;
+      }),
+      page.click('#button-remove'),
+      forceFlushReplay(),
+    ]);
 
     const replayData0 = getReplayRecordingContent(res0);
     const replayData1 = getReplayRecordingContent(res1);

packages/browser-integration-tests/suites/replay/largeMutations/mutationLimit/test.ts

@@ -34,8 +34,14 @@ sentryTest(
     const [res0] = await Promise.all([waitForReplayRequest(page, 0), gotoPageAndClick()]);
     await forceFlushReplay();
 
-    const [res1] = await Promise.all([waitForReplayRequest(page), page.click('#button-add')]);
-    await forceFlushReplay();
+    const [res1] = await Promise.all([
+      waitForReplayRequest(page, (_event, res) => {
+        const parsed = getReplayRecordingContent(res);
+        return !!parsed.incrementalSnapshots.length || !!parsed.fullSnapshots.length;
+      }),
+      page.click('#button-add'),
+      forceFlushReplay(),
+    ]);
 
     // replay should be stopped due to mutation limit
     let replay = await getReplaySnapshot(page);