Update cookie detection

Instead of looking at `req.cookies`, the parser will only detect cookies
set in headers because ultimately that is where middleware originally
grabs the information from. This results in a much simplified logic.

Author: Rui Marinho

lib/parsers.js

@@ -112,10 +112,10 @@ module.exports.parseRequest = function parseRequest(req, kwargs) {
     // cookies:
     //
     //   node: req.headers.cookie
-    //   express: req.cookies (expressjs/cookies)
+    //   express: req.headers.cookie
     //   koa: req.headers.cookie
     //
-    var cookies = (isPlainObject(req.cookies) ? req.cookies : '' ) || cookie.parse(headers.cookie || headers.cookies || '');
+    var cookies = cookie.parse(headers.cookie || '');
 
     // body data:
     //

package.json

@@ -25,21 +25,21 @@
   },
   "dependencies": {
     "cookie": "0.1.0",
-    "lodash._shimisplainobject": "^2.4.1",
     "lsmod": "~0.0.3",
     "node-uuid": "~1.4.1",
     "stack-trace": "0.0.7"
   },
   "devDependencies": {
-    "mocha": "*",
-    "should": "~3.3.1",
-    "nock": "*",
+    "coffee-script": "~1.7.1",
     "glob": "*",
+    "mocha": "*",
     "mock-udp": "*",
-    "coffee-script": "~1.7.1"
+    "nock": "*",
+    "should": "~3.3.1"
   },
   "optionalDependencies": {
     "connect": "*",
-    "express": "*"
+    "express": "*",
+    "koa": "*"
   }
 }

test/raven.parsers.js

@@ -1,6 +1,7 @@
 var assert = require('assert');
 var raven = require('../');
-var client = new raven.Client()
+var client = new raven.Client();
+
 raven.parsers = require('../lib/parsers');
 
 describe('raven.parsers', function(){
@@ -176,22 +177,6 @@ describe('raven.parsers', function(){
     });
 
     describe('`cookie` detection', function() {
-      it('should parse `req.cookies`', function(){
-        var mockReq = {
-          method: 'GET',
-          url: '/some/path?key=value',
-          headers: {
-            host: 'mattrobenolt.com',
-          },
-          cookies: {
-            foo: 'bar'
-          }
-        };
-
-        var parsed = raven.parsers.parseRequest(mockReq);
-        parsed['sentry.interfaces.Http'].cookies.should.eql({ foo: 'bar' });
-      });
-
       it('should parse `req.headers.cookie`', function(){
         var mockReq = {
           method: 'GET',
@@ -206,59 +191,20 @@ describe('raven.parsers', function(){
         parsed['sentry.interfaces.Http'].cookies.should.eql({ foo: 'bar' });
       });
 
-      it('should parse `req.headers.cookies`', function(){
+      it('should parse `req.header.cookie`', function(){
         var mockReq = {
           method: 'GET',
           url: '/some/path?key=value',
-          headers: {
-            host: 'mattrobenolt.com',
-            cookies: 'qux=foo'
-          }
-        };
-
-        var parsed = raven.parsers.parseRequest(mockReq);
-        parsed['sentry.interfaces.Http'].cookies.should.eql({ qux: 'foo' });
-      });
-
-      it('should parse `req.cookies`', function(){
-        var mockReq = {
-          method: 'GET',
-          url: '/some/path?key=value',
-          headers: {
+          header: {
             host: 'mattrobenolt.com',
-          },
-          cookies: {
-            foo: 'bar'
+            cookie: 'foo=bar'
           }
         };
 
         var parsed = raven.parsers.parseRequest(mockReq);
         parsed['sentry.interfaces.Http'].cookies.should.eql({ foo: 'bar' });
       });
 
-      it('should fallback to `req.headers.cookies` if `req.cookies` is not a plain object', function(){
-        var cookie = function Cookie(name, value) {
-          this.name = name;
-          this.value = value;
-        };
-
-        var cookies = function Cookies() {
-          this.cookies = [new Cookie('foo', 'bar')];
-        };
-
-        var mockReq = {
-          method: 'GET',
-          url: '/some/path?key=value',
-          headers: {
-            host: 'mattrobenolt.com',
-            cookie: 'qux=baz'
-          },
-          cookies: cookies
-        };
-
-        var parsed = raven.parsers.parseRequest(mockReq);
-        parsed['sentry.interfaces.Http'].cookies.should.eql({ qux: 'baz' });
-      });
     });
 
     describe('`query` detection', function() {