@@ -104,7 +104,7 @@ export class RequestData implements Integration {
104
104
// the moment it lives here, though, until https://github.com/getsentry/sentry-javascript/issues/5718 is addressed.
105
105
// (TL;DR: Those functions touch many parts of the repo in many different ways, and need to be clened up. Once
106
106
// that's happened, it will be easier to add this logic in without worrying about unexpected side effects.)
107
- const { include , addRequestData, transactionNamingScheme } = this . _options ;
107
+ const { addRequestData, transactionNamingScheme } = this . _options ;
108
108
109
109
addGlobalEventProcessor ( event => {
110
110
const hub = getCurrentHub ( ) ;
@@ -117,7 +117,9 @@ export class RequestData implements Integration {
117
117
return event ;
118
118
}
119
119
120
- const processedEvent = addRequestData ( event , req , { include : formatIncludeOption ( include ) } ) ;
120
+ const addRequestDataOptions = convertReqDataIntegrationOptsToAddReqDataOpts ( this . _options ) ;
121
+
122
+ const processedEvent = addRequestData ( event , req , addRequestDataOptions ) ;
121
123
122
124
// Transaction events already have the right `transaction` value
123
125
if ( event . type === 'transaction' || transactionNamingScheme === 'handler' ) {
@@ -151,12 +153,12 @@ export class RequestData implements Integration {
151
153
}
152
154
}
153
155
154
- /** Convert `include` option to match what `addRequestDataToEvent` expects */
156
+ /** Convert this integration's options to match what `addRequestDataToEvent` expects */
155
157
/** TODO: Can possibly be deleted once https://github.com/getsentry/sentry-javascript/issues/5718 is fixed */
156
- function formatIncludeOption (
157
- integrationInclude : RequestDataIntegrationOptions [ 'include' ] = { } ,
158
- ) : AddRequestDataToEventOptions [ 'include' ] {
159
- const { ip, user, ...requestOptions } = integrationInclude ;
158
+ function convertReqDataIntegrationOptsToAddReqDataOpts (
159
+ integrationOptions : RequestDataIntegrationOptions ,
160
+ ) : AddRequestDataToEventOptions {
161
+ const { ip, user, ...requestOptions } = integrationOptions . include ;
160
162
161
163
const requestIncludeKeys : string [ ] = [ ] ;
162
164
for ( const [ key , value ] of Object . entries ( requestOptions ) ) {
@@ -181,9 +183,11 @@ function formatIncludeOption(
181
183
}
182
184
183
185
return {
184
- ip,
185
- user : addReqDataUserOpt ,
186
- request : requestIncludeKeys . length !== 0 ? requestIncludeKeys : undefined ,
186
+ include : {
187
+ ip,
188
+ user : addReqDataUserOpt ,
189
+ request : requestIncludeKeys . length !== 0 ? requestIncludeKeys : undefined ,
190
+ } ,
187
191
} ;
188
192
}
189
193
0 commit comments