Skip to content

Commit 204d4ad

Browse files
committed
pass entire options object when reformatting include option
1 parent 80550c2 commit 204d4ad

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

packages/node/src/integrations/requestdata.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class RequestData implements Integration {
104104
// the moment it lives here, though, until https://github.com/getsentry/sentry-javascript/issues/5718 is addressed.
105105
// (TL;DR: Those functions touch many parts of the repo in many different ways, and need to be clened up. Once
106106
// that's happened, it will be easier to add this logic in without worrying about unexpected side effects.)
107-
const { include, addRequestData, transactionNamingScheme } = this._options;
107+
const { addRequestData, transactionNamingScheme } = this._options;
108108

109109
addGlobalEventProcessor(event => {
110110
const hub = getCurrentHub();
@@ -117,7 +117,9 @@ export class RequestData implements Integration {
117117
return event;
118118
}
119119

120-
const processedEvent = addRequestData(event, req, { include: formatIncludeOption(include) });
120+
const addRequestDataOptions = convertReqDataIntegrationOptsToAddReqDataOpts(this._options);
121+
122+
const processedEvent = addRequestData(event, req, addRequestDataOptions);
121123

122124
// Transaction events already have the right `transaction` value
123125
if (event.type === 'transaction' || transactionNamingScheme === 'handler') {
@@ -151,12 +153,12 @@ export class RequestData implements Integration {
151153
}
152154
}
153155

154-
/** Convert `include` option to match what `addRequestDataToEvent` expects */
156+
/** Convert this integration's options to match what `addRequestDataToEvent` expects */
155157
/** TODO: Can possibly be deleted once https://github.com/getsentry/sentry-javascript/issues/5718 is fixed */
156-
function formatIncludeOption(
157-
integrationInclude: RequestDataIntegrationOptions['include'] = {},
158-
): AddRequestDataToEventOptions['include'] {
159-
const { ip, user, ...requestOptions } = integrationInclude;
158+
function convertReqDataIntegrationOptsToAddReqDataOpts(
159+
integrationOptions: RequestDataIntegrationOptions,
160+
): AddRequestDataToEventOptions {
161+
const { ip, user, ...requestOptions } = integrationOptions.include;
160162

161163
const requestIncludeKeys: string[] = [];
162164
for (const [key, value] of Object.entries(requestOptions)) {
@@ -181,9 +183,11 @@ function formatIncludeOption(
181183
}
182184

183185
return {
184-
ip,
185-
user: addReqDataUserOpt,
186-
request: requestIncludeKeys.length !== 0 ? requestIncludeKeys : undefined,
186+
include: {
187+
ip,
188+
user: addReqDataUserOpt,
189+
request: requestIncludeKeys.length !== 0 ? requestIncludeKeys : undefined,
190+
},
187191
};
188192
}
189193

0 commit comments

Comments
 (0)