Skip to content

Commit 2385359

Browse files
committed
refactor extraerrorata
1 parent feb2bb5 commit 2385359

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

packages/integrations/src/extraerrordata.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,27 +75,23 @@ export class ExtraErrorData implements Integration {
7575
* Extract extra information from the Error object
7676
*/
7777
private _extractErrorData(error: ExtendedError): { [key: string]: unknown } | null {
78-
let result = null;
7978
// We are trying to enhance already existing event, so no harm done if it won't succeed
8079
try {
8180
const nativeKeys = ['name', 'message', 'stack', 'line', 'column', 'fileName', 'lineNumber', 'columnNumber'];
82-
const errorKeys = Object.getOwnPropertyNames(error).filter(key => nativeKeys.indexOf(key) === -1);
81+
const errorKeys = Object.getOwnPropertyNames(error).filter(key => !nativeKeys.includes(key));
8382

8483
if (errorKeys.length) {
8584
const extraErrorInfo: { [key: string]: unknown } = {};
8685
for (const key of errorKeys) {
87-
let value = error[key];
88-
if (isError(value)) {
89-
value = (value as Error).toString();
90-
}
91-
extraErrorInfo[key] = value;
86+
const value = error[key];
87+
extraErrorInfo[key] = isError(value) ? (value as Error).toString() : value;
9288
}
93-
result = extraErrorInfo;
89+
return extraErrorInfo;
9490
}
9591
} catch (oO) {
9692
logger.error('Unable to extract extra data from the Error object:', oO);
9793
}
9894

99-
return result;
95+
return null;
10096
}
10197
}

0 commit comments

Comments
 (0)