Skip to content

Commit 23ebb38

Browse files
committed
remove SeverityLevels
1 parent 6445db2 commit 23ebb38

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

packages/types/src/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ export {
4646
SessionFlusherLike,
4747
} from './session';
4848

49-
export { Severity } from './severity';
50-
export { SeverityLevel, SeverityLevels } from './severity';
49+
export { Severity, SeverityLevel } from './severity';
5150
export { Span, SpanContext } from './span';
5251
export { StackFrame } from './stackframe';
5352
export { Stacktrace, StackParser, StackLineParser, StackLineParserFn } from './stacktrace';

packages/types/src/severity.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@ export enum Severity {
2020

2121
// TODO: in v7, these can disappear, because they now also exist in `@sentry/utils`. (Having them there rather than here
2222
// is nice because then it enforces the idea that only types are exported from `@sentry/types`.)
23-
export const SeverityLevels = ['fatal', 'error', 'warning', 'log', 'info', 'debug', 'critical'] as const;
24-
export type SeverityLevel = typeof SeverityLevels[number];
23+
export type SeverityLevel = 'fatal' | 'error' | 'warning' | 'log' | 'info' | 'debug' | 'critical';

packages/utils/src/enums.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
export const SeverityLevels = ['fatal', 'error', 'warning', 'log', 'info', 'debug', 'critical'] as const;
2-
export type SeverityLevel = typeof SeverityLevels[number];
1+
export type SeverityLevel = 'fatal' | 'error' | 'warning' | 'log' | 'info' | 'debug' | 'critical';

packages/utils/src/severity.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import { Severity } from '@sentry/types';
22

3-
import { SeverityLevel, SeverityLevels } from './enums';
3+
import { SeverityLevel } from './enums';
4+
5+
export const validSeverityLevels = ['fatal', 'error', 'warning', 'log', 'info', 'debug', 'critical'];
46

57
function isSupportedSeverity(level: string): level is Severity {
6-
return SeverityLevels.indexOf(level as SeverityLevel) !== -1;
8+
return validSeverityLevels.indexOf(level as SeverityLevel) !== -1;
79
}
810
/**
911
* Converts a string-based level into a {@link Severity}.

packages/utils/test/severity.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { SeverityLevels } from '../src/enums';
2-
import { severityFromString } from '../src/severity';
1+
import { severityFromString, validSeverityLevels } from '../src/severity';
32

43
describe('severityFromString()', () => {
54
describe('normalize warn and warning', () => {
@@ -16,7 +15,7 @@ describe('severityFromString()', () => {
1615
expect(severityFromString('foo')).toBe('log');
1716
});
1817
describe('allows ', () => {
19-
for (const level of SeverityLevels) {
18+
for (const level of validSeverityLevels) {
2019
expect(severityFromString(level)).toBe(level);
2120
}
2221
});

0 commit comments

Comments
 (0)