try uploading all bundles

Author: AbhiPrasad

.github/workflows/build.yml

@@ -23,7 +23,6 @@ concurrency:
 
 env:
   HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}
-  CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
   # WARNING: this disables cross os caching as ~ and
   # github.workspace evaluate to differents paths
@@ -275,6 +274,9 @@ jobs:
             ${{needs.job_get_metadata.outputs.is_develop == 'false' && env.NX_CACHE_RESTORE_KEYS || 'nx-never-restore'}}
 
       - name: Build packages
+        # Set the CODECOV_TOKEN for Bundle Analysis
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         # Under normal circumstances, using the git SHA as a cache key, there shouldn't ever be a cache hit on the built
         # packages, and so `yarn build` should always run. This `if` check is therefore only there for testing CI issues
         # where the built packages are beside the point. In that case, you can change `BUILD_CACHE_KEY` (at the top of

dev-packages/rollup-utils/bundleHelpers.mjs

@@ -10,6 +10,7 @@ import {
   getEs5Polyfills,
   makeBrowserBuildPlugin,
   makeCleanupPlugin,
+  makeCodeCovPlugin,
   makeCommonJSPlugin,
   makeIsDebugBuildPlugin,
   makeLicensePlugin,
@@ -152,7 +153,7 @@ export function makeBaseBundleConfig(options) {
  * @returns An array of versions of that config
  */
 export function makeBundleConfigVariants(baseConfig, options = {}) {
-  const { variants = BUNDLE_VARIANTS } = options;
+  const { variants = BUNDLE_VARIANTS, bundleAnalysis = true } = options;
 
   const includeDebuggingPlugin = makeIsDebugBuildPlugin(true);
   const stripDebuggingPlugin = makeIsDebugBuildPlugin(false);
@@ -183,7 +184,7 @@ export function makeBundleConfigVariants(baseConfig, options = {}) {
     },
   };
 
-  return variants.map(variant => {
+  const bundles = variants.map(variant => {
     if (!BUNDLE_VARIANTS.includes(variant)) {
       throw new Error(`Unknown bundle variant requested: ${variant}`);
     }
@@ -193,4 +194,16 @@ export function makeBundleConfigVariants(baseConfig, options = {}) {
       customMerge: key => (key === 'plugins' ? mergePlugins : undefined),
     });
   });
+
+  if (bundleAnalysis) {
+    bundles.forEach(bundle => {
+      try {
+        bundle.plugins.push(makeCodeCovPlugin(bundle.output.entryFileNames()));
+      } catch (_) {
+        // empty
+      }
+    });
+  }
+
+  return bundles;
 }

dev-packages/rollup-utils/npmHelpers.mjs

@@ -29,7 +29,8 @@ export function makeBaseNPMConfig(options = {}) {
     hasBundles = false,
     packageSpecificConfig = {},
     addPolyfills = true,
-    bundleAnalysis,
+    bundleAnalysis = true,
+    bundleName,
   } = options;
 
   const nodeResolvePlugin = makeNodeResolvePlugin();
@@ -113,8 +114,8 @@ export function makeBaseNPMConfig(options = {}) {
     defaultBaseConfig.plugins.push(extractPolyfillsPlugin);
   }
 
-  if (bundleAnalysis && bundleAnalysis.length) {
-    defaultBaseConfig.plugins.push(makeCodeCovPlugin(bundleAnalysis));
+  if (bundleAnalysis) {
+    defaultBaseConfig.plugins.push(makeCodeCovPlugin(bundleName));
   }
 
   return deepMerge(defaultBaseConfig, packageSpecificConfig, {

dev-packages/rollup-utils/plugins/npmPlugins.mjs

@@ -7,6 +7,9 @@
  * Sucrase plugin docs: https://github.com/rollup/plugins/tree/master/packages/sucrase
  */
 
+import * as fs from 'fs';
+import * as path from 'path';
+
 import { codecovRollupPlugin } from '@codecov/rollup-plugin';
 import replace from '@rollup/plugin-replace';
 import sucrase from '@rollup/plugin-sucrase';
@@ -134,8 +137,18 @@ export function makeRrwebBuildPlugin({ excludeShadowDom, excludeIframe } = {}) {
 
 /**
  * Plugin that uploads bundle analysis to codecov.
+ *
+ * @param type The type of bundle being uploaded.
+ * @param prefix The prefix for the codecov bundle name. Defaults to 'npm'.
  */
-export function makeCodeCovPlugin(bundleName) {
+export function makeCodeCovPlugin(suffix) {
+  const packageJson = JSON.parse(fs.readFileSync(path.resolve(process.cwd(), './package.json'), { encoding: 'utf8' }));
+
+  let bundleName = packageJson.name;
+  if (suffix != undefined) {
+    bundleName += `:${suffix}`;
+  }
+
   return codecovRollupPlugin({
     enableBundleAnalysis: process.env.GITHUB_ACTIONS === 'true' && process.env.CODECOV_TOKEN,
     bundleName,

packages/nextjs/rollup.npm.config.mjs

@@ -23,6 +23,7 @@ export default [
   ),
   ...makeNPMConfigVariants(
     makeBaseNPMConfig({
+      bundleName: 'config',
       entrypoints: [
         'src/config/templates/apiWrapperTemplate.ts',
         'src/config/templates/middlewareWrapperTemplate.ts',
@@ -58,6 +59,7 @@ export default [
   ),
   ...makeNPMConfigVariants(
     makeBaseNPMConfig({
+      bundleName: 'loaders',
       entrypoints: ['src/config/loaders/index.ts'],
 
       packageSpecificConfig: {

packages/serverless/rollup.aws.config.mjs

@@ -27,6 +27,7 @@ export default [
   // launches (via the `NODE_OPTIONS="-r @sentry/serverless/dist/awslambda-auto"` variable). Note the inclusion in this
   // path of the legacy `dist` folder; for backwards compatibility, in the build script we'll copy the file there.
   makeBaseNPMConfig({
+    bundleName: 'awslambda-auto',
     entrypoints: ['src/awslambda-auto.ts'],
     packageSpecificConfig: {
       // Normally `makeNPMConfigVariants` sets both of these values for us, but we don't actually want the ESM variant,