Skip to content

Commit 25aed4d

Browse files
authored
ref(serverless): Improve handling of SDK version in GitHub action (#5100)
* Fix for properly handling SDK version in GitHub actions.
1 parent 8a4039d commit 25aed4d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ jobs:
103103
- name: Save SDK version for later
104104
run: |
105105
echo "Saving SDK_VERSION for later"
106-
export SDK_VERSION=$(cat packages/core/src/version.ts | cut -f5 -d' ' | tr -d "'" | tr -d ";")
107-
echo $SDK_VERSION > dist-serverless/version
106+
cat packages/core/src/version.ts | awk -F"'" '{print $2}' > dist-serverless/version
107+
[ -z $(cat dist-serverless/version) ] && echo "Version extraction failed" && exit 1
108+
108109
outputs:
109110
# this needs to be passed on, because the `needs` context only looks at direct ancestors (so steps which depend on
110111
# `job_build` can't see `job_install_deps` and what it returned)
@@ -533,8 +534,7 @@ jobs:
533534
- name: Get SDK version
534535
run: |
535536
export SDK_VERSION=$(cat dist-serverless/version)
536-
echo "SDK_VERSION=$SDK_VERSION"
537-
echo "SDK_VERSION=$SDK_VERSION" >> $GITHUB_ENV
537+
echo "SDK_VERSION=$SDK_VERSION" | tee -a $GITHUB_ENV
538538
- uses: actions/upload-artifact@v3
539539
with:
540540
name: ${{ env.HEAD_COMMIT }}

0 commit comments

Comments
 (0)