Skip to content

Commit 298dd2a

Browse files
committed
Remove unncessary server export of browser tracing integration
1 parent 59fb5d2 commit 298dd2a

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

packages/solidstart/src/server/solidrouter.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import type { Integration } from '@sentry/types';
21
import type { HashRouter, MemoryRouter, RouteSectionProps, Router as BaseRouter, StaticRouter } from '@solidjs/router';
32
import { mergeProps, splitProps } from 'solid-js';
43
import type { Component, JSX, ParentProps } from 'solid-js';
@@ -21,16 +20,7 @@ function withSentryRouterRoot(Root: Component<RouteSectionProps>): Component<Rou
2120
return SentryRouterRoot;
2221
}
2322

24-
/**
25-
* A browser tracing integration that uses Solid Router to instrument navigations.
26-
*/
27-
export function solidRouterBrowserTracingIntegration(_options: unknown): Integration {
28-
return {
29-
name: '[no-op] solidRouterBrowserTracingIntegration',
30-
};
31-
}
32-
33-
type RouterType = typeof BaseRouter | typeof HashRouter | typeof MemoryRouter | typeof StaticRouter;
23+
export type RouterType = typeof BaseRouter | typeof HashRouter | typeof MemoryRouter | typeof StaticRouter;
3424

3525
/**
3626
* A higher-order component to instrument Solid Router to create navigation spans.

packages/solidstart/src/solidrouter.types.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
export * from './client/solidrouter';
66
export * from './server/solidrouter';
77

8-
import type * as clientSolidRouter from './client/solidrouter';
9-
import type * as serverSolidRouter from './server/solidrouter';
8+
import type { RouterType } from './server/solidrouter';
109

11-
export declare const solidRouterBrowserTracingIntegration: typeof clientSolidRouter & typeof serverSolidRouter;
12-
13-
export declare const withSentryRouterRouting: typeof clientSolidRouter & typeof serverSolidRouter;
10+
export declare function withSentryRouterRouting(Router: RouterType): RouterType;

0 commit comments

Comments
 (0)