Skip to content

Commit 2a78ae4

Browse files
committed
s/traceparent/sentrytrace in various spots
1 parent da073dc commit 2a78ae4

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

packages/node/src/handlers.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@ export function tracingHandler(): (
5454
next: (error?: any) => void,
5555
): void {
5656
// If there is a trace header set, we extract the data from it (parentSpanId, traceId, and sampling decision)
57-
let traceparentData;
57+
let sentrytraceData;
5858
if (req.headers && isString(req.headers['sentry-trace'])) {
59-
traceparentData = extractSentrytraceData(req.headers['sentry-trace'] as string);
59+
sentrytraceData = extractSentrytraceData(req.headers['sentry-trace'] as string);
6060
}
6161

6262
const transaction = startTransaction(
6363
{
6464
name: extractExpressTransactionName(req, { path: true, method: true }),
6565
op: 'http.server',
66-
...traceparentData,
66+
...sentrytraceData,
6767
},
6868
// extra context passed to the tracesSampler
6969
{ request: extractRequestData(req) },

packages/serverless/src/awslambda.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,15 +253,15 @@ export function wrapHandler<TEvent, TResult>(
253253
}
254254

255255
// Applying `sentry-trace` to context
256-
let traceparentData;
256+
let sentrytraceData;
257257
const eventWithHeaders = event as { headers?: { [key: string]: string } };
258258
if (eventWithHeaders.headers && isString(eventWithHeaders.headers['sentry-trace'])) {
259-
traceparentData = extractSentrytraceData(eventWithHeaders.headers['sentry-trace'] as string);
259+
sentrytraceData = extractSentrytraceData(eventWithHeaders.headers['sentry-trace'] as string);
260260
}
261261
const transaction = startTransaction({
262262
name: context.functionName,
263263
op: 'awslambda.handler',
264-
...traceparentData,
264+
...sentrytraceData,
265265
});
266266

267267
const hub = getCurrentHub();

packages/serverless/src/gcpfunction/http.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,15 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
5050
const reqUrl = stripUrlQueryAndFragment(req.originalUrl || req.url || '');
5151

5252
// Applying `sentry-trace` to context
53-
let traceparentData;
53+
let sentrytraceData;
5454
const reqWithHeaders = req as { headers?: { [key: string]: string } };
5555
if (reqWithHeaders.headers && isString(reqWithHeaders.headers['sentry-trace'])) {
56-
traceparentData = extractSentrytraceData(reqWithHeaders.headers['sentry-trace'] as string);
56+
sentrytraceData = extractSentrytraceData(reqWithHeaders.headers['sentry-trace'] as string);
5757
}
5858
const transaction = startTransaction({
5959
name: `${reqMethod} ${reqUrl}`,
6060
op: 'gcp.function.http',
61-
...traceparentData,
61+
...sentrytraceData,
6262
});
6363

6464
// getCurrentHub() is expected to use current active domain as a carrier

packages/tracing/src/utils.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ export function hasTracingEnabled(
2828
/**
2929
* Extract transaction context data from a `sentry-trace` header.
3030
*
31-
* @param traceparent Traceparent string
31+
* @param header Traceparent string
3232
*
3333
* @returns Object containing data from the header, or undefined if traceparent string is malformed
3434
*/
35-
export function extractSentrytraceData(traceparent: string): TraceparentData | undefined {
36-
const matches = traceparent.match(SENTRY_TRACE_REGEX);
35+
export function extractSentrytraceData(header: string): TraceparentData | undefined {
36+
const matches = header.match(SENTRY_TRACE_REGEX);
37+
3738
if (matches) {
3839
let parentSampled: boolean | undefined;
3940
if (matches[3] === '1') {
@@ -47,6 +48,7 @@ export function extractSentrytraceData(traceparent: string): TraceparentData | u
4748
parentSpanId: matches[2],
4849
};
4950
}
51+
5052
return undefined;
5153
}
5254

0 commit comments

Comments
 (0)