Sentry wants stack frames from oldest to newest, lol

Author: mattrobenolt

src/raven.js

@@ -506,6 +506,9 @@ function processException(type, message, fileurl, lineno, frames, options) {
     if (globalOptions.ignoreErrors.test(message)) return;
 
     if (frames && frames.length) {
+        // Sentry expects frames oldest to newest
+        // and JS sends them as newest to oldest
+        frames.reverse();
         stacktrace = {frames: frames};
         fileurl = frames[0].filename || fileurl;
     } else if (fileurl) {

test/raven.test.js

@@ -399,47 +399,49 @@ describe('globals', function() {
 
             var frames = [
                 {
-                    filename: 'http://example.com/file1.js'
+                    filename: 'http://example.com/file2.js'
                 },
                 {
-                    filename: 'http://example.com/file2.js'
+                    filename: 'http://example.com/file1.js'
                 }
-            ];
+            ], framesFlipped = frames.slice(0);
+
+            framesFlipped.reverse();
 
-            processException('Error', 'lol', 'http://example.com/override.js', 10, frames, {});
+            processException('Error', 'lol', 'http://example.com/override.js', 10, frames.slice(0), {});
             assert.deepEqual(window.send.lastCall.args, [{
                 exception: {
                     type: 'Error',
                     value: 'lol'
                 },
                 stacktrace: {
-                    frames: frames
+                    frames: framesFlipped
                 },
                 culprit: 'http://example.com/file1.js',
                 message: 'lol at 10'
             }]);
 
-            processException('Error', 'lol', '', 10, frames, {});
+            processException('Error', 'lol', '', 10, frames.slice(0), {});
             assert.deepEqual(window.send.lastCall.args, [{
                 exception: {
                     type: 'Error',
                     value: 'lol'
                 },
                 stacktrace: {
-                    frames: frames
+                    frames: framesFlipped
                 },
                 culprit: 'http://example.com/file1.js',
                 message: 'lol at 10'
             }]);
 
-            processException('Error', 'lol', '', 10, frames, {extra: 'awesome'});
+            processException('Error', 'lol', '', 10, frames.slice(0), {extra: 'awesome'});
             assert.deepEqual(window.send.lastCall.args, [{
                 exception: {
                     type: 'Error',
                     value: 'lol'
                 },
                 stacktrace: {
-                    frames: frames
+                    frames: framesFlipped
                 },
                 culprit: 'http://example.com/file1.js',
                 message: 'lol at 10',