get it working

Author: AbhiPrasad

packages/tracing/src/idletransaction.ts

@@ -24,18 +24,18 @@ export class IdleTransactionSpanRecorder extends SpanRecorder {
    * @inheritDoc
    */
   public add(span: Span): void {
-    // tslint:disable-next-line: no-unbound-method
-    const oldFinish: Function = span.finish;
     span.finish = (endTimestamp?: number) => {
-      oldFinish(endTimestamp);
+      span.endTimestamp = typeof endTimestamp === 'number' ? endTimestamp : timestampWithMs();
       if (this._popActivity) {
         this._popActivity(span.spanId);
       }
     };
 
     super.add(span);
-    if (this._pushActivity && !span.endTimestamp) {
-      this._pushActivity(span.spanId);
+    if (span && !span.endTimestamp) {
+      if (this._pushActivity) {
+        this._pushActivity(span.spanId);
+      }
     }
   }
 }
@@ -71,10 +71,12 @@ export class IdleTransaction extends Transaction {
     if (hub) {
       // We set the transaction here on the scope so error events pick up the trace
       // context and attach it to the error.
+      logger.log('Setting transaction on scope');
       hub.configureScope(scope => scope.setSpan(this));
     }
 
-    // Start heartbeat so that transactions do not run forever.
+    // Start heartbeat so that transactions do not run forever.\
+    logger.log('Starting heartbeat');
     this._pingHeartbeat();
   }
 
@@ -141,7 +143,9 @@ export class IdleTransaction extends Transaction {
    * Finish the current active idle transaction
    */
   private _finishIdleTransaction(endTimestamp: number): void {
-    if (this.spanRecorder) {
+    if (this.spanRecorder && !this._finished) {
+      logger.log('[Tracing] finishing IdleTransaction', new Date(endTimestamp * 1000).toISOString());
+
       if (this._finishCallback) {
         this._finishCallback(this);
       }
@@ -183,6 +187,8 @@ export class IdleTransaction extends Transaction {
    * @param spanId The span id that represents the activity
    */
   private _pushActivity(spanId: string): void {
+    logger.log(`[Tracing] pushActivity: ${spanId}`);
+    logger.log('[Tracing] activies count', Object.keys(this.activities).length);
     this.activities[spanId] = true;
   }
 
@@ -192,6 +198,7 @@ export class IdleTransaction extends Transaction {
    */
   private _popActivity(spanId: string): void {
     if (this.activities[spanId]) {
+      logger.log(`[Tracing] popActivity ${spanId}`);
       // tslint:disable-next-line: no-dynamic-delete
       delete this.activities[spanId];
     }

packages/tracing/src/integrations/browsertracing.ts

@@ -188,6 +188,7 @@ export class BrowserTracing implements Integration {
    * Initialize routing instrumentation
    */
   private static _initRoutingInstrumentation(hub: Hub): void {
+    BrowserTracing.log('Set up Routing instrumentation');
     const {
       beforeNavigate,
       idleTimeout,

packages/tracing/src/integrations/tracing/router.ts

@@ -1,6 +1,6 @@
 import { Hub } from '@sentry/hub';
 import { TransactionContext } from '@sentry/types';
-import { addInstrumentationHandler, getGlobalObject, timestampWithMs } from '@sentry/utils';
+import { addInstrumentationHandler, getGlobalObject, timestampWithMs, logger } from '@sentry/utils';
 
 import { IdleTransaction } from '../../idletransaction';
 
@@ -158,6 +158,7 @@ export class RouterTracing implements RoutingInstrumentation {
     beforeFinish?: (transactionSpan: IdleTransaction) => void,
     transactionContext?: TransactionContext,
   ): void {
+    logger.log(`[Tracing] starting pageload transaction`);
     this._activeTransaction = this.startIdleTransaction(hub, 'pageload', transactionContext);
     if (this._activeTransaction && beforeFinish) {
       this._activeTransaction.beforeFinish(beforeFinish);
@@ -173,8 +174,10 @@ export class RouterTracing implements RoutingInstrumentation {
     transactionContext?: TransactionContext,
   ): void {
     if (this._activeTransaction) {
+      logger.log(`[Tracing] force ending previous transaction`);
       this._activeTransaction.finish(timestampWithMs());
     }
+    logger.log(`[Tracing] starting navigation transaction`);
     this._activeTransaction = this.startIdleTransaction(hub, 'navigation', transactionContext);
     if (this._activeTransaction && beforeFinish) {
       this._activeTransaction.beforeFinish(beforeFinish);