fix: Use utils in integrations, Remove incremental mode

Author: HazAT

packages/integrations/package.json

@@ -14,11 +14,11 @@
   },
   "main": "dist/index.js",
   "module": "esm/index.js",
-  "browser": "dist/index.js",
   "types": "dist/index.d.ts",
   "dependencies": {
     "@sentry/types": "5.2.0-beta.0",
-    "@sentry/utils": "5.2.0-beta.0"
+    "@sentry/utils": "5.2.0-beta.0",
+    "tslib": "^1.9.3"
   },
   "devDependencies": {
     "chai": "^4.1.2",

packages/integrations/src/tracing.ts

@@ -35,26 +35,26 @@ export class Tracing implements Integration {
    *
    * @param _options TracingOptions
    */
-  public constructor(private readonly _options: TracingOptions) {}
+  public constructor(private readonly _options: TracingOptions) {
+    if (!_options.tracingOrigins || !Array.isArray(_options.tracingOrigins) || _options.tracingOrigins.length === 0) {
+      throw new SentryError('You need to define `tracingOrigins` in the options. Set an array of urls to trace.');
+    }
+  }
 
   /**
    * @inheritDoc
    */
   public setupOnce(_: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void {
-    if (this._options.tracingOrigins.length) {
-      if (this._options.traceXHR !== false) {
-        this._traceXHR(getCurrentHub);
-      }
-      if (this._options.traceFetch !== false) {
-        this._traceFetch(getCurrentHub);
-      }
-      if (this._options.autoStartOnDomReady !== false) {
-        getGlobalObject<Window>().addEventListener('DOMContentLoaded', () => {
-          Tracing.startTrace(getCurrentHub(), getGlobalObject<Window>().location.href);
-        });
-      }
-    } else {
-      throw new SentryError('You need to define tracingOrigins in the options');
+    if (this._options.traceXHR !== false) {
+      this._traceXHR(getCurrentHub);
+    }
+    if (this._options.traceFetch !== false) {
+      this._traceFetch(getCurrentHub);
+    }
+    if (this._options.autoStartOnDomReady !== false) {
+      getGlobalObject<Window>().addEventListener('DOMContentLoaded', () => {
+        Tracing.startTrace(getCurrentHub(), getGlobalObject<Window>().location.href);
+      });
     }
   }
 
@@ -102,19 +102,19 @@ export class Tracing implements Integration {
         function(this: XMLHttpRequest, ...args: any[]): void {
           // @ts-ignore
           const self = getCurrentHub().getIntegration(Tracing);
-          if (self) {
+          if (self && self._xhrUrl) {
             const headers = getCurrentHub().traceHeaders();
             let whiteListed = false;
-
-            if (self._xhrUrl) {
-              self._options.tracingOrigins.forEach((whiteListUrl: string) => {
-                if (!whiteListed) {
-                  whiteListed = isMatchingPattern(self._xhrUrl, whiteListUrl);
-                }
-              });
+            // tslint:disable-next-line: prefer-for-of
+            for (let index = 0; index < self._options.tracingOrigins.length; index++) {
+              const whiteListUrl = self._options.tracingOrigins[index];
+              whiteListed = isMatchingPattern(self._xhrUrl, whiteListUrl);
+              if (whiteListed) {
+                break;
+              }
             }
 
-            if (whiteListed) {
+            if (whiteListed && this.setRequestHeader) {
               Object.keys(headers).forEach(key => {
                 this.setRequestHeader(key, headers[key]);
               });

packages/typescript/tsconfig.json

@@ -20,7 +20,6 @@
     "strict": true,
     "target": "es5",
     "strictBindCallApply": false,
-    "incremental": true,
     "plugins": [
       {
         "name": "typescript-tslint-plugin",