Skip to content

Commit 3203558

Browse files
authored
ref(sdk): Fix max lines eslint rule (#5577)
It's debatable whether this should be enabled at all, but at the very least we should relax the conditions that don't affect bundle size, such as blank lines and comments since it leads towards either disabling the rule entirely (as you can see in a lot of sdk files) or people not writing comments (again, not ideal).
1 parent dbd8340 commit 3203558

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/eslint-config-sdk/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ module.exports = {
212212
'prefer-template': 'error',
213213

214214
// Limit maximum file size to reduce complexity. Turned off in tests.
215-
'max-lines': 'error',
215+
'max-lines': ['error', { max: 300, skipComments: true, skipBlankLines: true }],
216216

217217
// We should require a whitespace beginning a comment
218218
'spaced-comment': [

0 commit comments

Comments
 (0)