Skip to content

Commit 32e72a1

Browse files
author
Luca Forstner
authored
fix(nextjs): Fix navigation tracing on app router (#10502)
1 parent 60a7d65 commit 32e72a1

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/client-app-routing-instrumentation.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ test('Creates a navigation transaction for app router routes', async ({ page })
3737
);
3838
});
3939

40-
const servercomponentTransactionPromise = waitForTransaction('nextjs-13-app-dir', async transactionEvent => {
40+
const serverComponentTransactionPromise = waitForTransaction('nextjs-13-app-dir', async transactionEvent => {
4141
return (
4242
transactionEvent?.transaction === 'Page Server Component (/server-component/parameter/[...parameters])' &&
4343
(await clientNavigationTransactionPromise).contexts?.trace?.trace_id ===
@@ -48,5 +48,5 @@ test('Creates a navigation transaction for app router routes', async ({ page })
4848
await page.getByText('/server-component/parameter/foo/bar/baz').click();
4949

5050
expect(await clientNavigationTransactionPromise).toBeDefined();
51-
expect(await servercomponentTransactionPromise).toBeDefined();
51+
expect(await serverComponentTransactionPromise).toBeDefined();
5252
});

packages/nextjs/src/common/wrapGenerationFunctionWithSentry.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
addTracingExtensions,
44
captureException,
55
getClient,
6+
getCurrentScope,
67
handleCallbackErrors,
78
startSpanManual,
89
withIsolationScope,
@@ -59,6 +60,7 @@ export function wrapGenerationFunctionWithSentry<F extends (...args: any[]) => a
5960

6061
const propagationContext = commonObjectToPropagationContext(headers, incomingPropagationContext);
6162
isolationScope.setPropagationContext(propagationContext);
63+
getCurrentScope().setPropagationContext(propagationContext);
6264

6365
return startSpanManual(
6466
{

packages/nextjs/src/common/wrapServerComponentWithSentry.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {
22
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
33
addTracingExtensions,
44
captureException,
5+
getCurrentScope,
56
handleCallbackErrors,
67
startSpanManual,
78
withIsolationScope,
@@ -51,6 +52,7 @@ export function wrapServerComponentWithSentry<F extends (...args: any[]) => any>
5152

5253
const propagationContext = commonObjectToPropagationContext(context.headers, incomingPropagationContext);
5354
isolationScope.setPropagationContext(propagationContext);
55+
getCurrentScope().setPropagationContext(propagationContext);
5456

5557
return startSpanManual(
5658
{

0 commit comments

Comments
 (0)