Skip to content

Commit 3345dfb

Browse files
committed
skip node install on alpine
1 parent 16ce0e5 commit 3345dfb

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1237,7 +1237,7 @@ jobs:
12371237
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
12381238
12391239
job_compile_bindings_profiling_node:
1240-
name: Compile profiling-node (v${{ matrix.node }}) ${{ matrix.target_platform || matrix.os }}, ${{ matrix.node || matrix.container }}, ${{ matrix.arch || matrix.container }}, ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }}
1240+
name: Compile profiling-node (v${{ matrix.node }}) ${{ matrix.target_platform || matrix.os }}, ${{ matrix.arch || matrix.container }}, ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }}
12411241
needs: [job_get_metadata, job_build]
12421242
# Compiling bindings can be very slow (especially on windows), so only run precompile
12431243
# Skip precompile unless we are on a release branch as precompile slows down CI times.
@@ -1365,8 +1365,13 @@ jobs:
13651365
with:
13661366
ref: ${{ env.HEAD_COMMIT }}
13671367

1368+
# Note: On alpine images, this does nothing
1369+
# The node version will be the one that is installed in the image
1370+
# If you want to change the node version, you need to change the image
1371+
# For non-alpine imgages, this will install the correct version of node
13681372
- name: Setup Node
13691373
uses: actions/setup-node@v4
1374+
if: contains(matrix.container, 'alpine') == false
13701375
with:
13711376
node-version: ${{ matrix.node }}
13721377

0 commit comments

Comments
 (0)