Merge branch 'develop' into onur/fix-flaky-remix-e2e-tests

Author: AbhiPrasad

.github/workflows/build.yml

@@ -136,7 +136,7 @@ jobs:
 
       - name: Get PR labels
         id: pr-labels
-        uses: mydea/pr-labels-action@update-core
+        uses: mydea/pr-labels-action@fn/bump-node20
 
     outputs:
       commit_label: '${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}'
@@ -165,8 +165,7 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 15
     if: |
-      (needs.job_get_metadata.outputs.is_gitflow_sync == 'false' && needs.job_get_metadata.outputs.has_gitflow_label == 'false') &&
-      (needs.job_get_metadata.outputs.changed_any_code == 'true' || github.event_name != 'pull_request')
+      (needs.job_get_metadata.outputs.is_gitflow_sync == 'false' && needs.job_get_metadata.outputs.has_gitflow_label == 'false')
     steps:
       - name: 'Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})'
         uses: actions/checkout@v4
@@ -213,8 +212,10 @@ jobs:
   job_build:
     name: Build
     needs: [job_get_metadata, job_install_deps]
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-20.04-large-js
     timeout-minutes: 30
+    if: |
+      (needs.job_get_metadata.outputs.changed_any_code == 'true' || github.event_name != 'pull_request')
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -319,10 +320,33 @@ jobs:
         env:
           DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
       - name: Lint source files
-        run: yarn lint
+        run: yarn lint:lerna
       - name: Validate ES5 builds
         run: yarn validate:es5
 
+  job_check_format:
+    name: Check file formatting
+    needs: [job_get_metadata, job_install_deps]
+    timeout-minutes: 10
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ env.HEAD_COMMIT }}
+      - name: Set up Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: 'package.json'
+      - name: Check dependency cache
+        uses: actions/cache/restore@v3
+        with:
+          path: ${{ env.CACHED_DEPENDENCY_PATHS }}
+          key: ${{ needs.job_install_deps.outputs.dependency_cache_key }}
+          fail-on-cache-miss: true
+      - name: Check file formatting
+        run: yarn lint:prettier && yarn lint:biome
+
   job_circular_dep_check:
     name: Circular Dependency Check
     needs: [job_get_metadata, job_build]
@@ -381,7 +405,7 @@ jobs:
     name: Browser Unit Tests
     needs: [job_get_metadata, job_build]
     timeout-minutes: 10
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -545,17 +569,16 @@ jobs:
           yarn test:integration
 
   job_browser_playwright_tests:
-    name: Playwright (${{ matrix.bundle }}) Tests
+    name: Playwright (${{ matrix.bundle }}${{ matrix.shard && format(' {0}/{1}', matrix.shard, matrix.shards) || ''}}) Tests
     needs: [job_get_metadata, job_build]
     if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-20.04-large-js
     timeout-minutes: 25
     strategy:
       fail-fast: false
       matrix:
         bundle:
           - esm
-          - cjs
           - bundle_es5
           - bundle_es5_min
           - bundle_es6
@@ -568,6 +591,36 @@ jobs:
           - bundle_tracing_es6_min
           - bundle_tracing_replay_es6
           - bundle_tracing_replay_es6_min
+        project:
+          - chromium
+        include:
+          # Only check all projects for esm & full bundle
+          # We also shard the tests as they take the longest
+          - bundle: bundle_tracing_replay_es6_min
+            project: ''
+            shard: 1
+            shards: 2
+          - bundle: bundle_tracing_replay_es6_min
+            project: ''
+            shard: 2
+            shards: 2
+          - bundle: esm
+            project: ''
+            shard: 1
+            shards: 3
+          - bundle: esm
+            shard: 2
+            shards: 3
+          - bundle: esm
+            project: ''
+            shard: 3
+            shards: 3
+        exclude:
+          # Do not run the default chromium-only tests
+          - bundle: bundle_tracing_replay_es6_min
+            project: 'chromium'
+          - bundle: esm
+            project: 'chromium'
 
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
@@ -605,9 +658,8 @@ jobs:
       - name: Run Playwright tests
         env:
           PW_BUNDLE: ${{ matrix.bundle }}
-        run: |
-          cd dev-packages/browser-integration-tests
-          yarn test:ci
+        working-directory: dev-packages/browser-integration-tests
+        run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 
   job_browser_loader_tests:
     name: Playwright Loader (${{ matrix.bundle }}) Tests
@@ -670,7 +722,7 @@ jobs:
     name: Browser (${{ matrix.browser }}) Tests
     needs: [job_get_metadata, job_build]
     if: needs.job_get_metadata.outputs.changed_browser == 'true' || github.event_name != 'pull_request'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-20.04-large-js
     timeout-minutes: 20
     strategy:
       fail-fast: false
@@ -727,6 +779,32 @@ jobs:
           cd packages/utils
           yarn test:package
 
+  job_check_for_faulty_dts:
+    name: Check for faulty .d.ts files
+    needs: [job_get_metadata, job_build]
+    runs-on: ubuntu-20.04
+    timeout-minutes: 5
+    steps:
+      - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ env.HEAD_COMMIT }}
+      - name: Set up Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: 'package.json'
+      - name: Restore caches
+        uses: ./.github/actions/restore-cache
+        env:
+          DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
+      - name: Check for dts files that reference stuff in the temporary build folder
+        run: |
+          if grep -r --include "*.d.ts" --exclude-dir ".nxcache" 'import("@sentry(-internal)?/[^/]*/build' .; then
+            echo "Found illegal TypeScript import statement."
+            exit 1
+          fi
+
+
   job_node_integration_tests:
     name:
       Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration
@@ -814,7 +892,7 @@ jobs:
       (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
       github.actor != 'dependabot[bot]'
     needs: [job_get_metadata, job_build]
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-20.04-large-js
     timeout-minutes: 15
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
@@ -868,6 +946,7 @@ jobs:
       matrix:
         test-application:
           [
+            'angular-17',
             'cloudflare-astro',
             'node-express-app',
             'create-react-app',
@@ -886,6 +965,7 @@ jobs:
             'generic-ts3.8',
             'node-experimental-fastify-app',
             'node-hapi-app',
+            'node-exports-test-app',
           ]
         build-command:
           - false
@@ -919,6 +999,9 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version-file: 'dev-packages/e2e-tests/package.json'
+      - name: Set up Bun
+        if: matrix.test-application == 'node-exports-test-app'
+        uses: oven-sh/setup-bun@v1
       - name: Restore caches
         uses: ./.github/actions/restore-cache
         env:
@@ -984,6 +1067,7 @@ jobs:
         job_e2e_tests,
         job_artifacts,
         job_lint,
+        job_check_format,
         job_circular_dep_check,
       ]
     # Always run this, even if a dependent job failed

.github/workflows/flaky-test-detector.yml

@@ -23,7 +23,7 @@ concurrency:
 
 jobs:
   flaky-detector:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-20.04-large-js
     timeout-minutes: 60
     name: 'Check tests for flakiness'
     # Also skip if PR is from master -> develop

.size-limit.js

@@ -47,6 +47,13 @@ module.exports = [
     gzip: true,
     limit: '35 KB',
   },
+  {
+    name: '@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)',
+    path: 'packages/browser/build/npm/esm/index.js',
+    import: '{ init, browserTracingIntegration }',
+    gzip: true,
+    limit: '35 KB',
+  },
   {
     name: '@sentry/browser (incl. Feedback) - Webpack (gzipped)',
     path: 'packages/browser/build/npm/esm/index.js',

CHANGELOG.md

@@ -4,6 +4,88 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.99.0
+
+### Important Changes
+
+#### Deprecations
+
+This release includes some deprecations for span related methods and integrations in our Deno SDK, `@sentry/deno`. For
+more details please look at our
+[migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md).
+
+- feat(core): Deprecate `Span.setHttpStatus` in favor of `setHttpStatus` (#10268)
+- feat(core): Deprecate `spanStatusfromHttpCode` in favour of `getSpanStatusFromHttpCode` (#10361)
+- feat(core): Deprecate `StartSpanOptions.origin` in favour of passing attribute (#10274)
+- feat(deno): Expose functional integrations to replace classes (#10355)
+
+### Other Changes
+
+- feat(bun): Add missing `@sentry/node` re-exports (#10396)
+- feat(core): Add `afterAllSetup` hook for integrations (#10345)
+- feat(core): Ensure `startSpan()` can handle spans that require parent (#10386)
+- feat(core): Read propagation context off scopes in `startSpan` APIs (#10300)
+- feat(remix): Export missing `@sentry/node` functions (#10385, #10391)
+- feat(serverless): Add missing `@sentry/node` re-exports (#10390)
+- feat(sveltekit): Add more missing `@sentry/node` re-exports (#10392)
+- feat(tracing): Export proper type for browser tracing (#10411)
+- feat(tracing): Expose new `browserTracingIntegration` (#10351)
+- fix: Ensure `afterAllSetup` is called when using `addIntegration()` (#10372)
+- fix(core): Export `spanToTraceContext` function from span utils (#10364)
+- fix(core): Make `FunctionToString` integration use SETUP_CLIENTS weakmap (#10358)
+- fix(deno): Call function if client is not setup (#10354)
+- fix(react): Fix attachReduxState option (#10381)
+- fix(spotlight): Use unpatched http.request (#10369)
+- fix(tracing): Only create request span if there is active span (#10375)
+- ref: Read propagation context off of scope and isolation scope when propagating and applying trace context (#10297)
+
+Work in this release contributed by @AleshaOleg. Thank you for your contribution!
+
+## 7.98.0
+
+This release primarily fixes some type declaration errors:
+
+- feat(core): Export `IntegrationIndex` type (#10337)
+- fix(nextjs): Fix Http integration type declaration (#10338)
+- fix(node): Fix type definitions (#10339)
+
+## 7.97.0
+
+Note: The 7.96.0 release was incomplete. This release is partially encompassing changes from `7.96.0`.
+
+- feat(react): Add `stripBasename` option for React Router 6 (#10314)
+
+## 7.96.0
+
+Note: This release was incomplete. Not all Sentry SDK packages were released for this version. Please upgrade to 7.98.0
+directly.
+
+### Important Changes
+
+#### Deprecations
+
+This release includes some deprecations for integrations in `@sentry/browser` and frontend framework SDKs
+(`@sentry/react`, `@sentry/vue`, etc.). Please take a look at our
+[migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md) for more details.
+
+- feat(browser): Export functional integrations & deprecate classes (#10267)
+
+#### Web Vitals Fix for LCP and CLS
+
+This release fixes an issue with the Web Vitals integration where LCP and CLS were not being captured correctly,
+increasing capture rate by 10-30% for some apps. LCP and CLS capturing issues were introduced with version `7.75.0`.
+
+- fix(tracing): Ensure web vitals are correctly stopped/captured (#10323)
+
+### Other Changes
+
+- fix(node): Fix `node-cron` types and add test (#10315)
+- fix(node): Fix downleveled types entry point (#10321)
+- fix(node): LocalVariables integration should use setupOnce (#10307)
+- fix(replay): Fix type for options of replayIntegration (#10325)
+
+Work in this release contributed by @Shubhdeep12. Thank you for your contribution!
+
 ## 7.95.0
 
 ### Important Changes
@@ -1058,7 +1140,7 @@ finished. This is useful for event emitters or similar.
 function middleware(_req, res, next) {
   return Sentry.startSpanManual({ name: 'middleware' }, (span, finish) => {
     res.once('finish', () => {
-      span?.setHttpStatus(res.status);
+      setHttpStatus(span, res.status);
       finish();
     });
     return next();

CONTRIBUTING.md

@@ -37,6 +37,12 @@ able to use it. From the top level of the repo, there are three commands availab
   dependencies (`utils`, `core`, `browser`, etc), and all packages which depend on it (currently `gatsby` and `nextjs`))
 - `yarn build:dev:watch`, which runs `yarn build:dev` in watch mode (recommended)
 
+You can also run a production build via `yarn build`, which will build everything except for the tarballs for publishing
+to NPM. You can use this if you want to bundle Sentry yourself. The build output can be found in the packages `build/`
+folder, e.g. `packages/browser/build`. Bundled files can be found in `packages/browser/build/bundles`. Note that there
+are no guarantees about the produced file names etc., so make sure to double check which files are generated after
+upgrading.
+
 ## Testing SDK Packages Locally
 
 To test local versions of SDK packages, for instance in test projects, you have a couple of options: