Skip to content

Commit 33fbefc

Browse files
committed
fix(tracing): Fix flakey web vitals LCP test
This has been super flakey for me... its possible that we were clicking button before image has loaded so that it thinks the LCP is the button. Closes #13115
1 parent 2d43b64 commit 33fbefc

File tree

1 file changed

+3
-2
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp

1 file changed

+3
-2
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
99
if (shouldSkipTracingTest() || browserName !== 'chromium') {
1010
sentryTest.skip();
1111
}
12-
12+
const imageSrc = 'https://example.com/path/to/image.png';
1313
page.route('**', route => route.continue());
1414
page.route('**/path/to/image.png', async (route: Route) => {
1515
return route.fulfill({ path: `${__dirname}/assets/sentry-logo-600x179.png` });
@@ -19,6 +19,7 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
1919
const [eventData] = await Promise.all([
2020
getFirstSentryEnvelopeRequest<Event>(page),
2121
page.goto(url),
22+
page.waitForResponse(imageSrc),
2223
page.locator('button').click(),
2324
]);
2425

@@ -27,5 +28,5 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
2728

2829
expect(eventData.contexts?.trace?.data?.['lcp.element']).toBe('body > img');
2930
expect(eventData.contexts?.trace?.data?.['lcp.size']).toBe(107400);
30-
expect(eventData.contexts?.trace?.data?.['lcp.url']).toBe('https://example.com/path/to/image.png');
31+
expect(eventData.contexts?.trace?.data?.['lcp.url']).toBe(imageSrc);
3132
});

0 commit comments

Comments
 (0)