Skip to content

Commit 3734404

Browse files
committed
force flush after inputs
1 parent 4069cf5 commit 3734404

File tree

1 file changed

+9
-8
lines changed
  • dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/hasSampling

1 file changed

+9
-8
lines changed

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/hasSampling/test.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,24 +39,25 @@ sentryTest('should capture feedback (@sentry-internal/feedback import)', async (
3939

4040
const [,,replayReq0] = await Promise.all([page.goto(url), page.getByText('Report a Bug').click(), reqPromise0]);
4141

42+
// Inputs are slow, these need to be serial
4243
await page.locator('[name="name"]').fill('Jane Doe');
4344
await page.locator('[name="email"]').fill('[email protected]');
4445
await page.locator('[name="message"]').fill('my example feedback');
4546

46-
const [,feedbackResp, replayReq1] = await Promise.all([page.getByLabel('Send Bug Report').click(), feedbackRequestPromise, reqPromise1]);
47+
// Force flush here, as inputs are slow and can cause click event to be in unpredictable segments
48+
await Promise.all([
49+
forceFlushReplay(),
50+
reqPromise1,
51+
]);
52+
53+
const [,feedbackResp, replayReq2] = await Promise.all([page.getByLabel('Send Bug Report').click(), feedbackRequestPromise, reqPromise2]);
4754

4855
const feedbackEvent = envelopeRequestParser(feedbackResp.request());
4956
const replayEvent = getReplayEvent(replayReq0);
5057
// Feedback breadcrumb is on second segment because we flush when "Report a Bug" is clicked
5158
// And then the breadcrumb is sent when feedback form is submitted
52-
const { breadcrumbs } = getCustomRecordingEvents(replayReq1);
53-
59+
const { breadcrumbs } = getCustomRecordingEvents(replayReq2);
5460

55-
if (breadcrumbs.length === 0) {
56-
console.log(getReplayEvent(replayReq0), getReplayEvent(replayReq1));
57-
console.log(getCustomRecordingEvents(replayReq0), getCustomRecordingEvents(replayReq1));
58-
console.log(getCustomRecordingEvents(await reqPromise2));
59-
}
6061

6162
expect(breadcrumbs).toEqual(
6263
expect.arrayContaining([

0 commit comments

Comments
 (0)