ref: Remove parentSpanId option

Author: AbhiPrasad

packages/apm/src/integrations/tracing.ts

@@ -770,15 +770,13 @@ export class Tracing implements Integration {
    * @param name Name of the activity, can be any string (Only used internally to identify the activity)
    * @param spanContext If provided a Span with the SpanContext will be created.
    * @param options _autoPopAfter_ | Time in ms, if provided the activity will be popped automatically after this timeout. This can be helpful in cases where you cannot gurantee your application knows the state and calls `popActivity` for sure.
-   * @param options _parentSpanId_ | Set a custom parent span id for the activity's span.
    */
   public static pushActivity(
     name: string,
     spanContext?: SpanContext,
     options?: {
       autoPopAfter?: number;
-      parentSpanId?: string;
-    },
+    },∂
   ): number {
     const activeTransaction = Tracing._activeTransaction;
 
@@ -792,9 +790,6 @@ export class Tracing implements Integration {
       const hub = _getCurrentHub();
       if (hub) {
         const span = activeTransaction.startChild(spanContext);
-        if (options && options.parentSpanId) {
-          span.parentSpanId = options.parentSpanId;
-        }
         Tracing._activities[Tracing._currentIndex] = {
           name,
           span,

packages/react/src/profiler.tsx

@@ -36,27 +36,16 @@ function warnAboutTracing(name: string): void {
  * Is a no-op if Tracing integration is not valid
  * @param name displayName of component that started activity
  */
-function pushActivity(
-  name: string,
-  op: string,
-  options?: {
-    autoPopAfter?: number;
-    parentSpanId?: string;
-  },
-): number | null {
+function pushActivity(name: string, op: string): number | null {
   if (globalTracingIntegration === null) {
     return null;
   }
 
   // tslint:disable-next-line:no-unsafe-any
-  return (globalTracingIntegration as any).constructor.pushActivity(
-    name,
-    {
-      description: `<${name}>`,
-      op: `react.${op}`,
-    },
-    options,
-  );
+  return (globalTracingIntegration as any).constructor.pushActivity(name, {
+    description: `<${name}>`,
+    op: `react.${op}`,
+  });
 }
 
 /**

packages/react/test/profiler.test.tsx

@@ -98,14 +98,10 @@ describe('withProfiler', () => {
       render(<ProfiledComponent />);
 
       expect(mockPushActivity).toHaveBeenCalledTimes(1);
-      expect(mockPushActivity).toHaveBeenLastCalledWith(
-        UNKNOWN_COMPONENT,
-        {
-          description: `<${UNKNOWN_COMPONENT}>`,
-          op: 'react.mount',
-        },
-        undefined,
-      );
+      expect(mockPushActivity).toHaveBeenLastCalledWith(UNKNOWN_COMPONENT, {
+        description: `<${UNKNOWN_COMPONENT}>`,
+        op: 'react.mount',
+      });
       expect(mockGetActivitySpan).toHaveBeenCalledTimes(1);
       expect(mockGetActivitySpan).toHaveBeenLastCalledWith(1);
 
@@ -198,14 +194,10 @@ describe('useProfiler()', () => {
       renderHook(() => useProfiler('Example'));
 
       expect(mockPushActivity).toHaveBeenCalledTimes(1);
-      expect(mockPushActivity).toHaveBeenLastCalledWith(
-        'Example',
-        {
-          description: '<Example>',
-          op: 'react.mount',
-        },
-        undefined,
-      );
+      expect(mockPushActivity).toHaveBeenLastCalledWith('Example', {
+        description: '<Example>',
+        op: 'react.mount',
+      });
       expect(mockGetActivitySpan).toHaveBeenCalledTimes(1);
       expect(mockGetActivitySpan).toHaveBeenLastCalledWith(1);