Apply code review suggestions

Simplify applyToEvent logic

Author: Lms24

packages/hub/src/scope.ts

@@ -471,12 +471,7 @@ export class Scope implements ScopeInterface {
     event.breadcrumbs = [...(event.breadcrumbs || []), ...this._breadcrumbs];
     event.breadcrumbs = event.breadcrumbs.length > 0 ? event.breadcrumbs : undefined;
 
-    // Since we're storing dynamic sampling context data in the event.sdkProcessingMetadata
-    // field We have to re-apply it after we applied the Scope's field.
-    // (This is because we're storing this data on the span and not on the scope)
-    const baggage = event.sdkProcessingMetadata && event.sdkProcessingMetadata.baggage;
-    event.sdkProcessingMetadata = this._sdkProcessingMetadata || {};
-    event.sdkProcessingMetadata.baggage = baggage;
+    event.sdkProcessingMetadata = { ...event.sdkProcessingMetadata, ...this._sdkProcessingMetadata };
 
     return this._notifyEventProcessors([...getGlobalEventProcessors(), ...this._eventProcessors], event, hint);
   }

packages/tracing/src/span.ts

@@ -384,7 +384,7 @@ export class Span implements SpanInterface {
     const { publicKey } = (client && client.getDsn()) || {};
 
     const metadata = this.transaction && this.transaction.metadata;
-    const sampelRate = metadata && metadata.transactionSampling && metadata.transactionSampling.rate;
+    const sampleRate = metadata && metadata.transactionSampling && metadata.transactionSampling.rate;
 
     const traceId = this.traceId;
 
@@ -402,15 +402,15 @@ export class Span implements SpanInterface {
     transactionName && setBaggageValue(baggage, 'transaction', transactionName);
     userId && setBaggageValue(baggage, 'userid', userId);
     userSegment && setBaggageValue(baggage, 'usersegment', userSegment);
-    sampelRate &&
+    sampleRate &&
       setBaggageValue(
         baggage,
         'samplerate',
         // This will make sure that expnent notation (e.g. 1.45e-14) is converted to simple decimal representation
         // Another edge case would be something like Number.NEGATIVE_INFINITY in which case we could still
         // add something like .replace(/-?∞/, '0'). For the sake of saving bytes, I'll not add this until
         // it becomes a problem
-        sampelRate.toLocaleString('fullwide', { useGrouping: false, maximumFractionDigits: 16 }),
+        sampleRate.toLocaleString('fullwide', { useGrouping: false, maximumFractionDigits: 16 }),
       );
     publicKey && setBaggageValue(baggage, 'publickey', publicKey);
     traceId && setBaggageValue(baggage, 'traceid', traceId);