ref: Remove isArray and isNaN utils

Author: kamilogorek

packages/core/src/dsn.ts

@@ -1,6 +1,5 @@
 import { DsnComponents, DsnLike, DsnProtocol } from '@sentry/types';
 import { SentryError } from '@sentry/utils/error';
-import { isNaN } from '@sentry/utils/is';
 
 /** Regular expression used to parse a Dsn. */
 const DSN_REGEX = /^(?:(\w+):)\/\/(?:(\w+)(?::(\w+))?@)([\w\.-]+)(?::(\d+))?\/(.+)/;
@@ -92,7 +91,7 @@ export class Dsn implements DsnComponents {
       throw new SentryError(`Invalid Dsn: Unsupported protocol "${this.protocol}"`);
     }
 
-    if (this.port && isNaN(parseInt(this.port, 10))) {
+    if (this.port && Number.isNaN(parseInt(this.port, 10))) {
       throw new SentryError(`Invalid Dsn: Invalid port number "${this.port}"`);
     }
   }

packages/utils/src/is.ts

@@ -95,17 +95,6 @@ export function isPrimitive(wat: any): boolean {
   return wat === null || (typeof wat !== 'object' && typeof wat !== 'function');
 }
 
-/**
- * Checks whether given value's type is an array
- * {@link isArray}.
- *
- * @param wat A value to be checked.
- * @returns A boolean representing the result.
- */
-export function isArray(wat: any): boolean {
-  return Object.prototype.toString.call(wat) === '[object Array]';
-}
-
 /**
  * Checks whether given value's type is an object literal
  * {@link isPlainObject}.
@@ -128,17 +117,6 @@ export function isRegExp(wat: any): boolean {
   return Object.prototype.toString.call(wat) === '[object RegExp]';
 }
 
-/**
- * Checks whether given value's type is a NaN
- * {@link isNaN}.
- *
- * @param wat A value to be checked.
- * @returns A boolean representing the result.
- */
-export function isNaN(wat: any): boolean {
-  return wat !== wat;
-}
-
 /**
  * Checks whether given value has a then function.
  * @param wat A value to be checked.

packages/utils/src/object.ts

@@ -146,7 +146,7 @@ export function serializeObject<T>(value: T, depth: number): T | string | {} {
     });
 
     return serialized;
-  } else if (isArray(value)) {
+  } else if (Array.isArray(value)) {
     const val = (value as any) as T[];
     return val.map(v => serializeObject(v, depth - 1));
   }
@@ -267,7 +267,7 @@ function normalizeValue(value: any, key?: any): any {
     return Object.getPrototypeOf(value) ? value.constructor.name : 'Event';
   }
 
-  if (isNaN(value)) {
+  if (Number.isNaN(value as number)) {
     return '[NaN]';
   }