Apply suggestions from code review

mydea · Lms24 · mydea · commit 3fa7f0a01e87 · 2024-02-12T12:00:28.000+01:00
Co-authored-by: Lukas Stracke &lt;lukas.stracke@sentry.io&gt;
diff --git a/packages/types/src/client.ts b/packages/types/src/client.ts
@@ -87,7 +87,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {
   /**
    * @inheritdoc
    *
-   * TODO (v8): Make this a required method.
    */
   getSdkMetadata(): SdkMetadata | undefined;
 
@@ -144,7 +143,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {
    * In most cases, this should not be necessary, and you're better off just passing the integrations via `integrations: []` at initialization time.
    * However, if you find the need to conditionally load & add an integration, you can use `addIntegration` to do so.
    *
-   * TODO (v8): Make this a required method.
    * */
   addIntegration(integration: Integration): void;
 

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {`
`87`	`87`	`/**`
`88`	`88`	`* @inheritdoc`
`89`	`89`	`*`
`90`		`- * TODO (v8): Make this a required method.`
`91`	`90`	`*/`
`92`	`91`	`getSdkMetadata(): SdkMetadata \| undefined;`
`93`	`92`
`@@ -144,7 +143,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {`
`144`	`143`	* In most cases, this should not be necessary, and you're better off just passing the integrations via `integrations: []` at initialization time.
`145`	`144`	* However, if you find the need to conditionally load & add an integration, you can use `addIntegration` to do so.
`146`	`145`	`*`
`147`		`- * TODO (v8): Make this a required method.`
`148`	`146`	`* */`
`149`	`147`	`addIntegration(integration: Integration): void;`
`150`	`148`