Skip to content

Commit 423931e

Browse files
committed
fix sharding
1 parent 6ff2a7f commit 423931e

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

.github/workflows/build.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ jobs:
569569
yarn test:integration
570570
571571
job_browser_playwright_tests:
572-
name: Playwright (${{ matrix.bundle }}) Tests
572+
name: Playwright (${{ matrix.bundle }}${{ matrix.shard && format(' {0}/3') || ''}}) Tests
573573
needs: [job_get_metadata, job_build]
574574
if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
575575
runs-on: ubuntu-20.04-large-js
@@ -595,12 +595,23 @@ jobs:
595595
- chromium
596596
include:
597597
# Only check all projects for esm & full bundle
598+
# We also shard the ESM tests as they take the longest
598599
- bundle: bundle_tracing_replay_es6_min
599600
project: ''
600601
- bundle: esm
601602
project: ''
602-
# We also shard the ESM tests as they take the longest
603-
shard: [1,2]
603+
shard: 1
604+
- bundle: esm
605+
shard: 2
606+
- bundle: esm
607+
project: ''
608+
shard: 3
609+
exclude:
610+
# Do not run the default chromium-only tests
611+
- bundle: bundle_tracing_replay_es6_min
612+
project: 'chromium'
613+
- bundle: esm
614+
project: 'chromium'
604615

605616
steps:
606617
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
@@ -639,7 +650,7 @@ jobs:
639650
env:
640651
PW_BUNDLE: ${{ matrix.bundle }}
641652
working-directory: dev-packages/browser-integration-tests
642-
run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/2', matrix.shard) || '' }}
653+
run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/3', matrix.shard) || '' }}
643654

644655
job_browser_loader_tests:
645656
name: Playwright Loader (${{ matrix.bundle }}) Tests

0 commit comments

Comments
 (0)