simplify heartbeatString creation

naseemkullah · naseemkullah · commit 43496a81a980 · 2021-09-18T14:49:57.000-04:00
diff --git a/packages/tracing/src/idletransaction.ts b/packages/tracing/src/idletransaction.ts
@@ -238,8 +238,7 @@ export class IdleTransaction extends Transaction {
       return;
     }
 
-    const keys = Object.keys(this.activities);
-    const heartbeatString = keys.length ? keys.reduce((prev: string, current: string) => prev + current) : '';
+    const heartbeatString = Object.keys(this.activities).join('');
 
     if (heartbeatString === this._prevHeartbeatString) {
       this._heartbeatCounter += 1;

Original file line number	Diff line number	Diff line change
`@@ -238,8 +238,7 @@ export class IdleTransaction extends Transaction {`
`238`	`238`	`return;`
`239`	`239`	`}`
`240`	`240`
`241`		`- const keys = Object.keys(this.activities);`
`242`		`- const heartbeatString = keys.length ? keys.reduce((prev: string, current: string) => prev + current) : '';`
	`241`	`+ const heartbeatString = Object.keys(this.activities).join('');`
`243`	`242`
`244`	`243`	`if (heartbeatString === this._prevHeartbeatString) {`
`245`	`244`	`this._heartbeatCounter += 1;`