Skip to content

Commit 4391242

Browse files
committed
Merge pull request #336 from benvinegar/fix-is-string
Improve isString to cover String objects
2 parents 00eef8d + 9942822 commit 4391242

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/raven.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ function isFunction(what) {
424424
}
425425

426426
function isString(what) {
427-
return typeof what === 'string';
427+
return objectPrototype.toString.call(what) === '[object String]';
428428
}
429429

430430
function isObject(what) {

test/raven.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ describe('globals', function() {
209209
describe('isString', function() {
210210
it('should do as advertised', function() {
211211
assert.isTrue(isString(''));
212+
assert.isTrue(isString(String('')));
213+
assert.isTrue(isString(new String('')));
212214
assert.isFalse(isString({}));
213215
assert.isFalse(isString(undefined));
214216
assert.isFalse(isString(function(){}));

0 commit comments

Comments
 (0)