rfc(volta): Update to use extends (#2930)

k-fish · web-flow · commit 4a11356e3b4f · 2020-09-23T09:53:42.000-07:00
When I was in the different packages I noticed that my node version would change.

As of Volta 0.8.2 you can use 'extends' for monorepo support, which helps pin node versions in all the packages (except where we need to special case it). Might be nice to have all of node pinned
diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -50,5 +50,8 @@
     "fix:eslint": "eslint . --format stylish --fix",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "sideEffects": false
 }
diff --git a/packages/apm/package.json b/packages/apm/package.json
@@ -60,6 +60,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -84,5 +84,8 @@
     "version": "node ../../scripts/versionbump.js src/version.ts",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "sideEffects": false
 }
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -50,6 +50,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json
@@ -41,5 +41,8 @@
     "lint": "prettier --check \"**/*.js\"",
     "fix": "prettier --write \"**/*.js\"",
     "pack": "npm pack"
+  },
+  "volta": {
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json
@@ -32,5 +32,8 @@
     "fix": "prettier --write \"{src,test}/**/*.js\"",
     "test": "mocha test --recursive",
     "pack": "npm pack"
+  },
+  "volta": {
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -62,6 +62,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -48,6 +48,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/integrations/package.json b/packages/integrations/package.json
@@ -56,6 +56,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/minimal/package.json b/packages/minimal/package.json
@@ -48,6 +48,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -63,6 +63,9 @@
     "version": "node ../../scripts/versionbump.js src/version.ts",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -76,6 +76,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/serverless/package.json b/packages/serverless/package.json
@@ -52,6 +52,9 @@
     "test:watch": "jest --watch --passWithNoTests",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "sideEffects": false,
   "jest": {
     "collectCoverage": true,
diff --git a/packages/tracing/package.json b/packages/tracing/package.json
@@ -62,6 +62,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {
diff --git a/packages/types/package.json b/packages/types/package.json
@@ -38,5 +38,8 @@
     "fix:eslint": "eslint . --format stylish --fix",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "sideEffects": false
 }
diff --git a/packages/typescript/package.json b/packages/typescript/package.json
@@ -21,5 +21,8 @@
   "scripts": {
     "link:yarn": "yarn link",
     "pack": "npm pack"
+  },
+  "volta": {
+    "extends": "../../package.json"
   }
 }
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -48,6 +48,9 @@
     "test:watch": "jest --watch",
     "pack": "npm pack"
   },
+  "volta": {
+    "extends": "../../package.json"
+  },
   "jest": {
     "collectCoverage": true,
     "transform": {

Original file line number	Diff line number	Diff line change
`@@ -50,5 +50,8 @@`
`50`	`50`	`"fix:eslint": "eslint . --format stylish --fix",`
`51`	`51`	`"pack": "npm pack"`
`52`	`52`	`},`
	`53`	`+ "volta": {`
	`54`	`+ "extends": "../../package.json"`
	`55`	`+ },`
`53`	`56`	`"sideEffects": false`
`54`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,5 +84,8 @@`
`84`	`84`	`"version": "node ../../scripts/versionbump.js src/version.ts",`
`85`	`85`	`"pack": "npm pack"`
`86`	`86`	`},`
	`87`	`+ "volta": {`
	`88`	`+ "extends": "../../package.json"`
	`89`	`+ },`
`87`	`90`	`"sideEffects": false`
`88`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,5 +41,8 @@`
`41`	`41`	`"lint": "prettier --check \"*/.js\"",`
`42`	`42`	`"fix": "prettier --write \"*/.js\"",`
`43`	`43`	`"pack": "npm pack"`
	`44`	`+ },`
	`45`	`+ "volta": {`
	`46`	`+ "extends": "../../package.json"`
`44`	`47`	`}`
`45`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,8 @@`
`32`	`32`	`"fix": "prettier --write \"{src,test}/*/.js\"",`
`33`	`33`	`"test": "mocha test --recursive",`
`34`	`34`	`"pack": "npm pack"`
	`35`	`+ },`
	`36`	`+ "volta": {`
	`37`	`+ "extends": "../../package.json"`
`35`	`38`	`}`
`36`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,5 +38,8 @@`
`38`	`38`	`"fix:eslint": "eslint . --format stylish --fix",`
`39`	`39`	`"pack": "npm pack"`
`40`	`40`	`},`
	`41`	`+ "volta": {`
	`42`	`+ "extends": "../../package.json"`
	`43`	`+ },`
`41`	`44`	`"sideEffects": false`
`42`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,8 @@`
`21`	`21`	`"scripts": {`
`22`	`22`	`"link:yarn": "yarn link",`
`23`	`23`	`"pack": "npm pack"`
	`24`	`+ },`
	`25`	`+ "volta": {`
	`26`	`+ "extends": "../../package.json"`
`24`	`27`	`}`
`25`	`28`	`}`