Ignore stack frames over 1kb (#6627)

Author: timfish

packages/browser/test/unit/tracekit/chromium.test.ts

@@ -547,4 +547,30 @@ describe('Tracekit - Chrome Tests', () => {
       },
     });
   });
+
+  it('should drop frames that are over 1kb', () => {
+    const LONG_STR = 'A'.repeat(1040);
+
+    const LONG_FRAME = {
+      message: 'bad',
+      name: 'Error',
+      stack: `Error: bad
+          at aha (http://localhost:5000/:39:5)
+          at Foo.testMethod (http://localhost:5000/${LONG_STR}:44:7)
+          at http://localhost:5000/:50:19`,
+    };
+
+    const ex = exceptionFromError(parser, LONG_FRAME);
+
+    expect(ex).toEqual({
+      value: 'bad',
+      type: 'Error',
+      stacktrace: {
+        frames: [
+          { filename: 'http://localhost:5000/', function: '?', lineno: 50, colno: 19, in_app: true },
+          { filename: 'http://localhost:5000/', function: 'aha', lineno: 39, colno: 5, in_app: true },
+        ],
+      },
+    });
+  });
 });

packages/utils/src/stacktrace.ts

@@ -16,6 +16,14 @@ export function createStackParser(...parsers: StackLineParser[]): StackParser {
     const frames: StackFrame[] = [];
 
     for (const line of stack.split('\n').slice(skipFirst)) {
+      // Ignore lines over 1kb as they are unlikely to be stack frames.
+      // Many of the regular expressions use backtracking which results in run time that increases exponentially with
+      // input size. Huge strings can result in hangs/Denial of Service:
+      // https://github.com/getsentry/sentry-javascript/issues/2286
+      if (line.length > 1024) {
+        continue;
+      }
+
       // https://github.com/getsentry/sentry-javascript/issues/5459
       // Remove webpack (error: *) wrappers
       const cleanedLine = line.replace(/\(error: (.*)\)/, '$1');