test(browser): Add integration tests for setTag (#4346)

onurtemizkan · web-flow · commit 4d28de1f699e · 2021-12-21T11:45:49.000-05:00
diff --git a/packages/integration-tests/suites/public-api/setTag/init.js b/packages/integration-tests/suites/public-api/setTag/init.js
@@ -0,0 +1,7 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+});
diff --git a/packages/integration-tests/suites/public-api/setTag/template.hbs b/packages/integration-tests/suites/public-api/setTag/template.hbs
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  <script src="{{htmlWebpackPlugin.options.initialization}}"></script>
+  </head>
+  <body>
+    <script src="{{htmlWebpackPlugin.options.subject}}"></script>
+  </body>
+</html>
diff --git a/packages/integration-tests/suites/public-api/setTag/with_non_primitives/subject.js b/packages/integration-tests/suites/public-api/setTag/with_non_primitives/subject.js
@@ -0,0 +1,7 @@
+Sentry.setTag('tag_1', {});
+Sentry.setTag('tag_2', []);
+Sentry.setTag('tag_3', ['a', new Map()]);
+Sentry.setTag('tag_4');
+Sentry.setTag('tag_5', () => {});
+
+Sentry.captureMessage('non_primitives');
diff --git a/packages/integration-tests/suites/public-api/setTag/with_non_primitives/test.ts b/packages/integration-tests/suites/public-api/setTag/with_non_primitives/test.ts
@@ -0,0 +1,13 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getSentryRequest } from '../../../../utils/helpers';
+
+sentryTest('should not accept non-primitive tags', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getSentryRequest(page, url);
+
+  expect(eventData.message).toBe('non_primitives');
+  expect(eventData.tags).toMatchObject({});
+});
diff --git a/packages/integration-tests/suites/public-api/setTag/with_primitives/subject.js b/packages/integration-tests/suites/public-api/setTag/with_primitives/subject.js
@@ -0,0 +1,8 @@
+Sentry.setTag('tag_1', 'foo');
+Sentry.setTag('tag_2', Math.PI);
+Sentry.setTag('tag_3', false);
+Sentry.setTag('tag_4', null);
+Sentry.setTag('tag_5', undefined);
+Sentry.setTag('tag_6', -1);
+
+Sentry.captureMessage('primitive_tags');
diff --git a/packages/integration-tests/suites/public-api/setTag/with_primitives/test.ts b/packages/integration-tests/suites/public-api/setTag/with_primitives/test.ts
@@ -0,0 +1,19 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getSentryRequest } from '../../../../utils/helpers';
+
+sentryTest('should set primitive tags', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getSentryRequest(page, url);
+
+  expect(eventData.message).toBe('primitive_tags');
+  expect(eventData.tags).toMatchObject({
+    tag_1: 'foo',
+    tag_2: 3.141592653589793,
+    tag_3: false,
+    tag_4: null,
+    tag_6: -1,
+  });
+});

-Original file line number
+Diff line change
@@ @@ -0,0 +1,7 @@ @@
 +import * as Sentry from '@sentry/browser';
++
 +window.Sentry = Sentry;
++
 +Sentry.init({
 +  dsn: 'https://[email protected]/1337',
 +});