Skip to content

Commit 4fe4281

Browse files
committed
test(browser-integration-tests): Check for full equality in error event trace context
1 parent 0cceb71 commit 4fe4281

File tree

3 files changed

+26
-4
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/trace-lifetime

3 files changed

+26
-4
lines changed

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,15 @@ sentryTest('error during navigation has new navigation traceId', async ({ getLoc
9696
expect(navigationTraceContext).not.toHaveProperty('parent_span_id');
9797

9898
const errorTraceContext = errorEvent?.contexts?.trace;
99-
expect(errorTraceContext).toMatchObject({
99+
expect(errorTraceContext).toEqual({
100+
data: {
101+
'sentry.op': 'navigation',
102+
'sentry.origin': 'auto.navigation.browser',
103+
'sentry.sample_rate': 1,
104+
'sentry.source': 'url',
105+
},
100106
op: 'navigation',
107+
origin: 'auto.navigation.browser',
101108
trace_id: errorTraceContext?.trace_id,
102109
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
103110
});

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ sentryTest('error after <meta> tag pageload has pageload traceId', async ({ getL
6464
await page.locator('#errorBtn').click();
6565
const errorEvent = await errorEventPromise;
6666

67-
expect(errorEvent.contexts?.trace).toMatchObject({
67+
expect(errorEvent.contexts?.trace).toEqual({
6868
trace_id: META_TAG_TRACE_ID,
6969
parent_span_id: META_TAG_PARENT_SPAN_ID,
7070
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
@@ -93,7 +93,15 @@ sentryTest('error during <meta> tag pageload has pageload traceId', async ({ get
9393
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
9494
});
9595

96-
expect(errorEvent?.contexts?.trace).toMatchObject({
96+
expect(errorEvent?.contexts?.trace).toEqual({
97+
data: {
98+
'sentry.op': 'pageload',
99+
'sentry.origin': 'auto.pageload.browser',
100+
'sentry.sample_rate': 1,
101+
'sentry.source': 'url',
102+
},
103+
op: 'pageload',
104+
origin: 'auto.pageload.browser',
97105
trace_id: META_TAG_TRACE_ID,
98106
parent_span_id: META_TAG_PARENT_SPAN_ID,
99107
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,15 @@ sentryTest('error during pageload has pageload traceId', async ({ getLocalTestPa
9393
expect(pageloadTraceContext).not.toHaveProperty('parent_span_id');
9494

9595
const errorTraceContext = errorEvent?.contexts?.trace;
96-
expect(errorTraceContext).toMatchObject({
96+
expect(errorTraceContext).toEqual({
97+
data: {
98+
'sentry.op': 'pageload',
99+
'sentry.origin': 'auto.pageload.browser',
100+
'sentry.sample_rate': 1,
101+
'sentry.source': 'url',
102+
},
97103
op: 'pageload',
104+
origin: 'auto.pageload.browser',
98105
trace_id: pageloadTraceContext?.trace_id,
99106
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
100107
});

0 commit comments

Comments
 (0)