ref: PR feedback

mydea · mydea · commit 50d837e67d35 · 2022-12-14T14:49:01.000+01:00
diff --git a/packages/core/src/baseclient.ts b/packages/core/src/baseclient.ts
@@ -629,8 +629,8 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
       return rejectedSyncPromise(new SentryError('SDK not enabled, will not capture event.', 'log'));
     }
 
-    const isTransaction = event.type === 'transaction';
-    const isError = !event.type;
+    const isTransaction = isTransactionEvent(event);
+    const isError = isErrorEvent(event);
     const eventType = event.type || 'error';
     const beforeSendLabel = `before send for type \`${eventType}\``;
 

Original file line number	Diff line number	Diff line change
`@@ -629,8 +629,8 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {`
`629`	`629`	`return rejectedSyncPromise(new SentryError('SDK not enabled, will not capture event.', 'log'));`
`630`	`630`	`}`
`631`	`631`
`632`		`- const isTransaction = event.type === 'transaction';`
`633`		`- const isError = !event.type;`
	`632`	`+ const isTransaction = isTransactionEvent(event);`
	`633`	`+ const isError = isErrorEvent(event);`
`634`	`634`	`const eventType = event.type \|\| 'error';`
`635`	`635`	const beforeSendLabel = `before send for type \`${eventType}\``;
`636`	`636`