Merge branch 'develop' into abhi-vue-deprecations

Author: AbhiPrasad

.github/ISSUE_TEMPLATE/flaky.yml

@@ -18,7 +18,7 @@ body:
     id: job-name
     attributes:
       label: Name of Job
-      placeholder: Build & Test / Nextjs (Node 10) Tests
+      placeholder: Build & Test / Nextjs (Node 14) Tests
       description: name of job as reported in the status report
     validations:
       required: true

.github/workflows/build.yml

@@ -523,7 +523,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [8, 10, 12, 14, 16, 18, 20, 21]
+        node: [14, 16, 18, 20, 21]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -540,9 +540,7 @@ jobs:
       - name: Run tests
         env:
           NODE_VERSION: ${{ matrix.node }}
-        run: |
-          [[ $NODE_VERSION == 8 ]] && yarn add --dev --ignore-engines --ignore-scripts --ignore-workspace-root-check [email protected]
-          yarn test-ci-node
+        run: yarn test-ci-node
       - name: Compute test coverage
         uses: codecov/codecov-action@v4
         with:
@@ -585,7 +583,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [10, 12, 14, 16, 18, 20, 21]
+        node: [14, 16, 18, 20, 21]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -612,12 +610,12 @@ jobs:
           path: ${{ steps.npm-cache-dir.outputs.dir }}
           key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
       - name: Install Playwright browser if not cached
-        if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
         run: npx playwright install --with-deps
         env:
           PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
       - name: Install OS dependencies of Playwright if cache hit
-        if: steps.playwright-cache.outputs.cache-hit == 'true' && matrix.node >= 14
+        if: steps.playwright-cache.outputs.cache-hit == 'true'
         run: npx playwright install-deps
       - name: Run tests
         env:
@@ -874,7 +872,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [10, 12, 14, 16, 18, 20, 21]
+        node: [14, 16, 18, 20, 21]
         typescript:
           - false
         include:

MIGRATION.md

@@ -1,3 +1,16 @@
+# Upgrading from 7.x to 8.x
+
+## Removal of Severity Enum
+
+In v7 we deprecated the `Severity` enum in favor of using the `SeverityLevel` type. In v8 we removed the `Severity`
+enum. If you were using the `Severity` enum, you should replace it with the `SeverityLevel` type. See
+[below](#severity-severitylevel-and-severitylevels) for code snippet examples
+
+## Removal of the `Offline` integration
+
+The `Offline` integration has been removed in favor of the offline transport wrapper:
+http://docs.sentry.io/platforms/javascript/configuration/transports/#offline-caching
+
 # Deprecations in 7.x
 
 You can use the **Experimental** [@sentry/migr8](https://www.npmjs.com/package/@sentry/migr8) to automatically update

dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts

@@ -28,11 +28,14 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr
 
   // Ensure window.open() still works as expected
   const context = browser.contexts()[0];
-  const waitForNewPage = context.waitForEvent('page');
 
-  await page.locator('#windowOpenButton').click();
+  const [reqResponse1] = await Promise.all([
+    reqPromise1,
+    context.waitForEvent('page'),
+    page.locator('#windowOpenButton').click(),
+  ]);
 
-  const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1);
+  const { breadcrumbs } = getCustomRecordingEvents(reqResponse1);
 
   // Filter out potential blur breadcrumb, as otherwise this can be flaky
   const filteredBreadcrumb = breadcrumbs.filter(breadcrumb => breadcrumb.category !== 'ui.blur');
@@ -57,8 +60,6 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr
     },
   ]);
 
-  await waitForNewPage;
-
   const pages = context.pages();
 
   expect(pages.length).toBe(2);

dev-packages/browser-integration-tests/suites/wasm/init.js

@@ -1,11 +1,11 @@
 import * as Sentry from '@sentry/browser';
-import { Wasm } from '@sentry/wasm';
+import { wasmIntegration } from '@sentry/wasm';
 
 window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: [new Wasm()],
+  integrations: [wasmIntegration()],
   beforeSend: event => {
     window.events.push(event);
     return null;

dev-packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/index.tsx

@@ -1,5 +1,4 @@
 import * as Sentry from '@sentry/react';
-import { BrowserTracing } from '@sentry/tracing';
 import React from 'react';
 import ReactDOM from 'react-dom/client';
 import {
@@ -18,14 +17,12 @@ Sentry.init({
   environment: 'qa', // dynamic sampling bias to keep transactions
   dsn: process.env.REACT_APP_E2E_TEST_DSN,
   integrations: [
-    new BrowserTracing({
-      routingInstrumentation: Sentry.reactRouterV6Instrumentation(
-        React.useEffect,
-        useLocation,
-        useNavigationType,
-        createRoutesFromChildren,
-        matchRoutes,
-      ),
+    Sentry.reactRouterV6BrowserTracingIntegration({
+      useEffect: React.useEffect,
+      useLocation,
+      useNavigationType,
+      createRoutesFromChildren,
+      matchRoutes,
     }),
   ],
   // We recommend adjusting this value in production, or using tracesSampler

dev-packages/node-integration-tests/suites/express/tracing-experimental/test.ts

@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('express tracing experimental', () => {
+describe('express tracing experimental', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });

dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/test.ts

@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('CJS - should instrument GraphQL queries used from Apollo Server.', done => {
     const EXPECTED_TRANSACTION = {
       transaction: 'Test Transaction',

dev-packages/node-integration-tests/suites/tracing-experimental/hapi/test.ts

@@ -1,9 +1,8 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('hapi auto-instrumentation', () => {
+describe('hapi auto-instrumentation', () => {
   afterAll(async () => {
     cleanupChildProcesses();
   });

dev-packages/node-integration-tests/suites/tracing-experimental/mongodb/test.ts

@@ -1,11 +1,10 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('MongoDB experimental Test', () => {
+describe('MongoDB experimental Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {

dev-packages/node-integration-tests/suites/tracing-experimental/mongoose/test.ts

@@ -1,11 +1,10 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('Mongoose experimental Test', () => {
+describe('Mongoose experimental Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {

dev-packages/node-integration-tests/suites/tracing-experimental/mysql/test.ts

@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('mysql auto instrumentation', () => {
+describe('mysql auto instrumentation', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });

dev-packages/node-integration-tests/suites/tracing-experimental/mysql2/test.ts

@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('mysql2 auto instrumentation', () => {
+describe('mysql2 auto instrumentation', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });

dev-packages/node-integration-tests/suites/tracing-experimental/postgres/test.ts

@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('postgres auto instrumentation', () => {
+describe('postgres auto instrumentation', () => {
   test('should auto-instrument `pg` package', done => {
     const EXPECTED_TRANSACTION = {
       transaction: 'Test Transaction',

dev-packages/node-integration-tests/suites/tracing-new/apollo-graphql/test.ts

@@ -1,8 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-// Node 10 is not supported by `graphql-js`
-// Ref: https://github.com/graphql/graphql-js/blob/main/package.json
-conditionalTest({ min: 12 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('should instrument GraphQL and Apollo Server.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });

dev-packages/node-integration-tests/suites/tracing-new/auto-instrument/mongodb/test.ts

@@ -1,11 +1,11 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../../utils';
 
 // This test can take longer.
 jest.setTimeout(15000);
 
-conditionalTest({ min: 12 })('MongoDB Test', () => {
+describe('MongoDB Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {

dev-packages/node-integration-tests/suites/tracing-new/prisma-orm/test.ts

@@ -1,6 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
+describe('Prisma ORM Integration', () => {
   test('should instrument Prisma client for tracing.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/test.ts

@@ -1,8 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-// Node 10 is not supported by `graphql-js`
-// Ref: https://github.com/graphql/graphql-js/blob/main/package.json
-conditionalTest({ min: 12 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('should instrument GraphQL and Apollo Server.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });

dev-packages/node-integration-tests/suites/tracing/auto-instrument/mongodb/test.ts

@@ -1,11 +1,11 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../../utils';
 
 // This test can take longer.
 jest.setTimeout(15000);
 
-conditionalTest({ min: 12 })('MongoDB Test', () => {
+describe('MongoDB Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {

dev-packages/node-integration-tests/suites/tracing/prisma-orm/test.ts

@@ -1,6 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
+describe('Prisma ORM Integration', () => {
   test('should instrument Prisma client for tracing.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });

dev-packages/rollup-utils/plugins/bundlePlugins.mjs

@@ -116,12 +116,6 @@ export function makeTerserPlugin() {
         reserved: [
           // ...except for `_experiments`, which we want to remain usable from the outside
           '_experiments',
-          // ...except for some localforage internals, which if we replaced them would break the localforage package
-          // with the error "Error: Custom driver not compliant": https://github.com/getsentry/sentry-javascript/issues/5527.
-          // Reference for which fields are affected: https://localforage.github.io/localForage/ (ctrl-f for "_")
-          '_driver',
-          '_initStorage',
-          '_support',
           // We want to keep some replay fields unmangled to enable integration tests to access them
           '_replay',
           '_canvas',

packages/angular/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "main": "build/bundles/sentry-angular.umd.js",
   "module": "build/fesm2015/sentry-angular.js",

packages/browser/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",

packages/browser/src/client.ts

@@ -9,7 +9,6 @@ import type {
   EventHint,
   Options,
   ParameterizedString,
-  Severity,
   SeverityLevel,
   UserFeedback,
 } from '@sentry/types';
@@ -76,8 +75,7 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
    */
   public eventFromMessage(
     message: ParameterizedString,
-    // eslint-disable-next-line deprecation/deprecation
-    level: Severity | SeverityLevel = 'info',
+    level: SeverityLevel = 'info',
     hint?: EventHint,
   ): PromiseLike<Event> {
     return eventFromMessage(this._options.stackParser, message, level, hint, this._options.attachStacktrace);

packages/browser/src/eventbuilder.ts

@@ -4,7 +4,6 @@ import type {
   EventHint,
   Exception,
   ParameterizedString,
-  Severity,
   SeverityLevel,
   StackFrame,
   StackParser,
@@ -178,8 +177,7 @@ export function eventFromException(
 export function eventFromMessage(
   stackParser: StackParser,
   message: ParameterizedString,
-  // eslint-disable-next-line deprecation/deprecation
-  level: Severity | SeverityLevel = 'info',
+  level: SeverityLevel = 'info',
   hint?: EventHint,
   attachStacktrace?: boolean,
 ): PromiseLike<Event> {

packages/browser/src/exports.ts

@@ -6,8 +6,6 @@ export type {
   Event,
   EventHint,
   Exception,
-  // eslint-disable-next-line deprecation/deprecation
-  Severity,
   SeverityLevel,
   StackFrame,
   Stacktrace,

packages/bun/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",

packages/bun/src/index.ts

@@ -8,8 +8,6 @@ export type {
   EventHint,
   Exception,
   Session,
-  // eslint-disable-next-line deprecation/deprecation
-  Severity,
   SeverityLevel,
   Span,
   StackFrame,

packages/core/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",