fix(replay): Handle worker compression errors

Author: mydea

packages/replay/src/eventBuffer/EventBufferCompressionWorker.ts

@@ -1,6 +1,7 @@
 import { logger } from '@sentry/utils';
 
 import type { AddEventResult, EventBuffer, RecordingEvent, WorkerRequest, WorkerResponse } from '../types';
+import { ReplayRecordingData } from '@sentry/types';
 
 /**
  * Event buffer that uses a web worker to compress events.
@@ -101,8 +102,15 @@ export class EventBufferCompressionWorker implements EventBuffer {
   /**
    * Finish the event buffer and return the compressed data.
    */
-  public finish(): Promise<Uint8Array> {
-    return this._finishRequest(this._getAndIncrementId());
+  public async finish(): Promise<ReplayRecordingData> {
+    try {
+      return await this._finishRequest(this._getAndIncrementId());
+    } catch (error) {
+      __DEBUG_BUILD__ && logger.error('[Replay] Error when trying to compress events', error);
+      // fall back to uncompressed
+      const events = this.pendingEvents;
+      return JSON.stringify(events);
+    }
   }
 
   /**

packages/replay/test/unit/eventBuffer.test.ts

@@ -2,9 +2,9 @@ import 'jsdom-worker';
 
 import pako from 'pako';
 
+import { EventBufferProxy } from '../../src/eventBuffer/EventBufferProxy';
 import { createEventBuffer } from './../../src/eventBuffer';
 import { BASE_TIMESTAMP } from './../index';
-import { EventBufferProxy } from '../../src/eventBuffer/EventBufferProxy';
 
 const TEST_EVENT = { data: {}, timestamp: BASE_TIMESTAMP, type: 3 };
 describe('Unit | eventBuffer', () => {
@@ -145,6 +145,31 @@ describe('Unit | eventBuffer', () => {
       expect(restored1).toEqual(JSON.stringify([TEST_EVENT]));
       expect(restored2).toEqual(JSON.stringify([{ ...TEST_EVENT, type: 5 }]));
     });
+
+    it('handles an error when compressing the payload xxx', async function () {
+      const buffer = createEventBuffer({
+        useCompression: true,
+      }) as EventBufferProxy;
+
+      expect(buffer).toBeInstanceOf(EventBufferProxy);
+
+      // Ensure worker is ready
+      await buffer.ensureWorkerIsLoaded();
+
+      buffer.addEvent(TEST_EVENT);
+      buffer.addEvent(TEST_EVENT);
+
+      // @ts-ignore Mock this private so it triggers an error
+      const postMessageSpy = jest.spyOn(buffer._compression, '_postMessage').mockImplementation(() => {
+        return Promise.reject('test worker error');
+      });
+
+      const result = await buffer.finish();
+
+      expect(postMessageSpy).toHaveBeenCalledTimes(1);
+
+      expect(result).toEqual(JSON.stringify([TEST_EVENT, TEST_EVENT]));
+    });
   });
 
   describe('EventBufferProxy fallback', () => {