Skip to content

Commit 54ccce8

Browse files
committed
use array type
1 parent e2b2f1b commit 54ccce8

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

packages/browser/src/transports/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export abstract class BaseTransport implements Transport {
138138
quantity: outcomes[key],
139139
};
140140
// TODO: Improve types on discarded_events to get rid of cast
141-
}) as ClientReport['discarded_events'];
141+
}) as Array<ClientReport['discarded_events']>;
142142
const envelope = createClientReportEnvelope(discardedEvents, this._api.tunnel && dsnToString(this._api.dsn));
143143

144144
try {

packages/types/src/envelope.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export type UserFeedbackItem = BaseEnvelopeItem<UserFeedbackItemHeaders, UserFee
3838
export type SessionItem =
3939
| BaseEnvelopeItem<SessionItemHeaders, Session>
4040
| BaseEnvelopeItem<SessionAggregatesItemHeaders, SessionAggregates>;
41-
export type ClientReportItem = BaseEnvelopeItem<ClientReportItemHeaders, ClientReport>;
41+
export type ClientReportItem = BaseEnvelopeItem<ClientReportItemHeaders, Array<ClientReport>>;
4242

4343
type EventEnvelopeHeaders = { event_id: string; sent_at: string };
4444
type SessionEnvelopeHeaders = { sent_at: string };

packages/utils/src/clientreport.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { dateTimestampInSeconds } from './time';
99
* @param dsn A DSN that can be set on the header. Optional.
1010
*/
1111
export function createClientReportEnvelope(
12-
discarded_events: ClientReport['discarded_events'],
12+
discarded_events: Array<ClientReport['discarded_events']>,
1313
dsn?: string,
1414
timestamp?: number,
1515
): ClientReportEnvelope {

packages/utils/test/clientreport.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createClientReportEnvelope } from '../src/clientreport';
22
import { serializeEnvelope } from '../src/envelope';
33
import { ClientReport } from '@sentry/types';
44

5-
const DEFAULT_DISCARDED_EVENTS: ClientReport['discarded_events'] = [
5+
const DEFAULT_DISCARDED_EVENTS: Array<ClientReport['discarded_events']> = [
66
{
77
reason: 'before_send',
88
category: 'event',

0 commit comments

Comments
 (0)