rename fetch callback

Author: lobsterkatie

packages/tracing/src/browser/request.ts

@@ -114,7 +114,7 @@ export function registerRequestInstrumentation(_options?: Partial<RequestInstrum
   if (traceFetch) {
     addInstrumentationHandler({
       callback: (handlerData: FetchData) => {
-        _fetchCallback(handlerData, shouldCreateSpan, spans);
+        fetchCallback(handlerData, shouldCreateSpan, spans);
       },
       type: 'fetch',
     });
@@ -133,7 +133,7 @@ export function registerRequestInstrumentation(_options?: Partial<RequestInstrum
 /**
  * Create and track fetch request spans
  */
-export function _fetchCallback(
+export function fetchCallback(
   handlerData: FetchData,
   shouldCreateSpan: (url: string) => boolean,
   spans: Record<string, Span>,

packages/tracing/test/browser/request.test.ts

@@ -2,7 +2,7 @@ import { BrowserClient } from '@sentry/browser';
 import { Hub, makeMain } from '@sentry/hub';
 
 import { Span, SpanStatus, Transaction } from '../../src';
-import { _fetchCallback, FetchData, registerRequestInstrumentation } from '../../src/browser/request';
+import { fetchCallback, FetchData, registerRequestInstrumentation } from '../../src/browser/request';
 import { addExtensionMethods } from '../../src/hubextensions';
 
 declare global {
@@ -96,7 +96,7 @@ describe('_fetchCallback()', () => {
     };
     const spans = {};
 
-    _fetchCallback(data, shouldCreateSpan, spans);
+    fetchCallback(data, shouldCreateSpan, spans);
     expect(spans).toEqual({});
   });
 
@@ -108,7 +108,7 @@ describe('_fetchCallback()', () => {
     };
     const spans = {};
 
-    _fetchCallback(data, shouldCreateSpan, spans);
+    fetchCallback(data, shouldCreateSpan, spans);
     expect(spans).toEqual({});
   });
 
@@ -125,7 +125,7 @@ describe('_fetchCallback()', () => {
     const spans: Record<string, Span> = {};
 
     // Start fetch request
-    _fetchCallback(data, shouldCreateSpan, spans);
+    fetchCallback(data, shouldCreateSpan, spans);
     const spanKey = Object.keys(spans)[0];
 
     const fetchSpan = spans[spanKey];
@@ -149,7 +149,7 @@ describe('_fetchCallback()', () => {
     };
 
     // End fetch request
-    _fetchCallback(newData, shouldCreateSpan, spans);
+    fetchCallback(newData, shouldCreateSpan, spans);
     expect(spans).toEqual({});
     if (transaction.spanRecorder) {
       expect(transaction.spanRecorder.spans[1].endTimestamp).toBeDefined();
@@ -171,15 +171,15 @@ describe('_fetchCallback()', () => {
     const spans: Record<string, Span> = {};
 
     // Start fetch request
-    _fetchCallback(data, shouldCreateSpan, spans);
+    fetchCallback(data, shouldCreateSpan, spans);
 
     const newData = {
       ...data,
       endTimestamp: data.startTimestamp + 12343234,
       response: { status: 404 } as Response,
     };
     // End fetch request
-    _fetchCallback(newData, shouldCreateSpan, spans);
+    fetchCallback(newData, shouldCreateSpan, spans);
     if (transaction.spanRecorder) {
       expect(transaction.spanRecorder.spans[1].status).toBe(SpanStatus.fromHttpCode(404));
     } else {