Skip to content

Commit 5ce8a4f

Browse files
committed
Explicitly support Node 14+ for Ember
1 parent f779a80 commit 5ce8a4f

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -404,11 +404,8 @@ jobs:
404404
- name: Set up Node
405405
uses: actions/setup-node@v3
406406
with:
407-
# The only danger with Ember in terms of Node versions is that the build tool, ember-cli, won't work if Node
408-
# is too old. Since Oct 2019, Node 10 has been the oldest version supported by ember-cli, so test against
409-
# that. If it passes, newer versions of Node should also be fine. This saves us from having to run the Ember
410-
# tests in our Node matrix above.
411-
node-version: '10'
407+
# We support node 14+. If that works, we can safely assume that newer versions will also work.
408+
node-version: '14'
412409
- name: Check dependency cache
413410
uses: actions/cache@v3
414411
with:

packages/ember/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ ENV['@sentry/ember'] = {
172172

173173
### Supported Versions
174174

175-
`@sentry/ember` currently supports Ember **4.0+** for error monitoring.
175+
* **Ember.js**: v4.0 or above
176+
* **Node**: v14 or above
176177

177178
### Previous Integration
178179

0 commit comments

Comments
 (0)