ref(replay): Avoid overwriting user checkoutEveryNms config

Author: mydea

packages/replay/src/replay.ts

@@ -158,8 +158,6 @@ export class ReplayContainer {
     // when an error will occur, so we need to keep a buffer of
     // replay events.
     if (this.session.sampled === 'error') {
-      // Checkout every minute, meaning we only get up-to one minute of events before the error happens
-      this.recordingOptions.checkoutEveryNms = 60000;
       this._waitForError = true;
     }
 
@@ -187,6 +185,7 @@ export class ReplayContainer {
     try {
       this._stopRecording = record({
         ...this.recordingOptions,
+        ...this._getRecordingOptionsOverwrites(),
         emit: this.handleRecordingEmit,
       });
     } catch (err) {
@@ -470,7 +469,6 @@ export class ReplayContainer {
           this._stopRecording();
           // Reset all "capture on error" configuration before
           // starting a new recording
-          delete this.recordingOptions.checkoutEveryNms;
           this._waitForError = false;
           this.startRecording();
         }
@@ -1283,4 +1281,16 @@ export class ReplayContainer {
 
     client.recordDroppedEvent = this._originalRecordDroppedEvent;
   }
+
+  /** Additional recordingOptions that should take precedence over user config */
+  private _getRecordingOptionsOverwrites(): Partial<RecordingOptions> {
+    return this._waitForError
+      ? {
+          // Checkout every minute, meaning we only get up-to one minute of events before the error happens
+          // Without this, it would record forever, until an error happens, which we don't want
+          // instead, we'll always keep the last 60 seconds of replay before an error happened
+          checkoutEveryNth: 60000,
+        }
+      : {};
+  }
 }