File tree Expand file tree Collapse file tree 4 files changed +63
-0
lines changed Expand file tree Collapse file tree 4 files changed +63
-0
lines changed Original file line number Diff line number Diff line change @@ -161,6 +161,15 @@ export class Span implements SpanInterface {
161
161
}
162
162
}
163
163
164
+ /** An alias for `description` of the Span. */
165
+ public get name ( ) : string {
166
+ return this . description || '' ;
167
+ }
168
+ /** Update the name of the span. */
169
+ public set name ( name : string ) {
170
+ this . setName ( name ) ;
171
+ }
172
+
164
173
/**
165
174
* @inheritDoc
166
175
*/
Original file line number Diff line number Diff line change
1
+ import { Span } from '../../../src' ;
2
+
3
+ describe ( 'span' , ( ) => {
4
+ it ( 'works with name' , ( ) => {
5
+ const span = new Span ( { name : 'span name' } ) ;
6
+ expect ( span . name ) . toEqual ( 'span name' ) ;
7
+ expect ( span . description ) . toEqual ( 'span name' ) ;
8
+ } ) ;
9
+
10
+ it ( 'works with description' , ( ) => {
11
+ const span = new Span ( { description : 'span name' } ) ;
12
+ expect ( span . name ) . toEqual ( 'span name' ) ;
13
+ expect ( span . description ) . toEqual ( 'span name' ) ;
14
+ } ) ;
15
+
16
+ it ( 'works without name' , ( ) => {
17
+ const span = new Span ( { } ) ;
18
+ expect ( span . name ) . toEqual ( '' ) ;
19
+ expect ( span . description ) . toEqual ( undefined ) ;
20
+ } ) ;
21
+
22
+ it ( 'allows to update the name' , ( ) => {
23
+ const span = new Span ( { name : 'span name' } ) ;
24
+ expect ( span . name ) . toEqual ( 'span name' ) ;
25
+ expect ( span . description ) . toEqual ( 'span name' ) ;
26
+
27
+ span . name = 'new name' ;
28
+
29
+ expect ( span . name ) . toEqual ( 'new name' ) ;
30
+ expect ( span . description ) . toEqual ( 'new name' ) ;
31
+ } ) ;
32
+ } ) ;
Original file line number Diff line number Diff line change
1
+ import { Transaction } from '../../../src' ;
2
+
3
+ describe ( 'transaction' , ( ) => {
4
+ it ( 'works with name' , ( ) => {
5
+ const transaction = new Transaction ( { name : 'span name' } ) ;
6
+ expect ( transaction . name ) . toEqual ( 'span name' ) ;
7
+ } ) ;
8
+
9
+ it ( 'allows to update the name' , ( ) => {
10
+ const transaction = new Transaction ( { name : 'span name' } ) ;
11
+ expect ( transaction . name ) . toEqual ( 'span name' ) ;
12
+
13
+ transaction . name = 'new name' ;
14
+
15
+ expect ( transaction . name ) . toEqual ( 'new name' ) ;
16
+ } ) ;
17
+ } ) ;
Original file line number Diff line number Diff line change @@ -88,6 +88,11 @@ export interface SpanContext {
88
88
89
89
/** Span holding trace_id, span_id */
90
90
export interface Span extends SpanContext {
91
+ /**
92
+ * Human-readable identifier for the span. Identical to span.description.
93
+ */
94
+ name : string ;
95
+
91
96
/**
92
97
* @inheritDoc
93
98
*/
You can’t perform that action at this time.
0 commit comments