move iife-mimicking code from add-on bundles' config into central config

Author: lobsterkatie

packages/integrations/rollup.config.js

@@ -5,7 +5,7 @@ import typescript from 'rollup-plugin-typescript2';
 import resolve from '@rollup/plugin-node-resolve';
 import commonjs from '@rollup/plugin-commonjs';
 
-import { baseBundleConfig, markAsBrowserBuild, paths } from '../../rollup.config';
+import { addOnBundleConfig, baseBundleConfig, markAsBrowserBuild, paths } from '../../rollup.config';
 
 const terserInstance = terser({
   mangle: {
@@ -42,18 +42,6 @@ const plugins = [
   commonjs(),
 ];
 
-function mergeIntoSentry() {
-  return `
-  __window.Sentry = __window.Sentry || {};
-  __window.Sentry.Integrations = __window.Sentry.Integrations || {};
-  for (var key in exports) {
-    if (Object.prototype.hasOwnProperty.call(exports, key)) {
-      __window.Sentry.Integrations[key] = exports[key];
-    }
-  }
-  `;
-}
-
 function allIntegrations() {
   return fs.readdirSync('./src').filter(file => file != 'index.ts');
 }
@@ -75,13 +63,9 @@ function loadAllIntegrations() {
         ...baseBundleConfig,
         input: `src/${file}`,
         output: {
-          banner: '(function (__window) {',
-          intro: 'var exports = {};',
-          outro: mergeIntoSentry(),
-          footer: '}(window));',
           ...baseBundleConfig.output,
+          ...addOnBundleConfig.output,
           file: `build/${file.replace('.ts', build.extension)}`,
-          format: 'cjs',
         },
         plugins: build.plugins,
       })),

packages/wasm/rollup.config.js

@@ -1,7 +1,7 @@
 import typescript from 'rollup-plugin-typescript2';
 import resolve from '@rollup/plugin-node-resolve';
 
-import { baseBundleConfig, paths, markAsBrowserBuild, terserPlugin } from '../../rollup.config';
+import { addOnBundleConfig, baseBundleConfig, paths, markAsBrowserBuild, terserPlugin } from '../../rollup.config';
 
 const plugins = [
   typescript({
@@ -23,18 +23,6 @@ const plugins = [
   }),
 ];
 
-function mergeIntoSentry() {
-  return `
-  __window.Sentry = __window.Sentry || {};
-  __window.Sentry.Integrations = __window.Sentry.Integrations || {};
-  for (var key in exports) {
-    if (Object.prototype.hasOwnProperty.call(exports, key)) {
-      __window.Sentry.Integrations[key] = exports[key];
-    }
-  }
-  `;
-}
-
 function loadAllIntegrations() {
   const builds = [];
   [
@@ -51,13 +39,9 @@ function loadAllIntegrations() {
       ...baseBundleConfig,
       input: `src/index.ts`,
       output: {
-        banner: '(function (__window) {',
-        intro: 'var exports = {};',
-        outro: mergeIntoSentry(),
-        footer: '}(window));',
         ...baseBundleConfig.output,
+        ...addOnBundleConfig.output,
         file: `build/wasm${build.extension}`,
-        format: 'cjs',
       },
       plugins: build.plugins,
     });

rollup.config.js

@@ -67,3 +67,34 @@ export const baseBundleConfig = {
   },
   treeshake: 'smallest',
 };
+
+export const addOnBundleConfig = {
+  // These output settings are designed to mimic an IIFE. We don't use Rollup's `iife` format because we don't want to
+  // attach this code to a new global variable, but rather inject it into the existing SDK's `Integrations` object.
+  output: {
+    format: 'cjs',
+
+    // code to add before the CJS wrapper
+    banner: '(function (__window) {',
+
+    // code to add just inside the CJS wrapper, before any of the wrapped code
+    intro: 'var exports = {};',
+
+    // code to add after all of the wrapped code, but still inside the CJS wrapper
+    outro: () =>
+      [
+        '',
+        "  // Add this module's exports to the global `Sentry.Integrations`",
+        '  __window.Sentry = __window.Sentry || {};',
+        '  __window.Sentry.Integrations = __window.Sentry.Integrations || {};',
+        '  for (var key in exports) {',
+        '    if (Object.prototype.hasOwnProperty.call(exports, key)) {',
+        '      __window.Sentry.Integrations[key] = exports[key];',
+        '    }',
+        '  }',
+      ].join('\n'),
+
+    // code to add after the CJS wrapper
+    footer: '}(window));',
+  },
+};