Skip to content

Commit 684dd65

Browse files
author
Luca Forstner
committed
Wait for res close in tests
1 parent b61b646 commit 684dd65

File tree

2 files changed

+7
-3
lines changed
  • dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation
  • packages/nextjs/test/integration/pages/api/http

2 files changed

+7
-3
lines changed

dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ export const dynamic = 'force-dynamic';
55
export default async function Page() {
66
await fetch('http://example.com/', { cache: 'no-cache' });
77
await new Promise<void>(resolve => {
8-
http.get('http://example.com/', () => {
9-
resolve();
8+
http.get('http://example.com/', res => {
9+
res.on('close', resolve);
1010
});
1111
});
1212
return <p>Hello World!</p>;

packages/nextjs/test/integration/pages/api/http/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import { NextApiRequest, NextApiResponse } from 'next';
33

44
const handler = async (_req: NextApiRequest, res: NextApiResponse): Promise<void> => {
55
// make an outgoing request in order to test that the `Http` integration creates a span
6-
await new Promise(resolve => get('http://example.com', resolve));
6+
await new Promise(resolve =>
7+
get('http://example.com', res => {
8+
res.on('close', resolve);
9+
}),
10+
);
711

812
res.status(200).json({});
913
};

0 commit comments

Comments
 (0)