feat(types): Move NewTransport types into types package

Author: AbhiPrasad

packages/core/src/transports/base.ts

@@ -1,4 +1,12 @@
-import { Envelope, EventStatus } from '@sentry/types';
+import {
+  Envelope,
+  InternalBaseTransportOptions,
+  NewTransport,
+  TransportCategory,
+  TransportRequest,
+  TransportRequestExecutor,
+  TransportResponse,
+} from '@sentry/types';
 import {
   disabledUntil,
   eventStatusFromHttpCode,
@@ -21,50 +29,6 @@ export const ATTACHMENT_TRANSPORT_CATEGORY = 'attachment';
 
 export const SESSION_TRANSPORT_CATEGORY = 'session';
 
-type TransportCategory =
-  | typeof ERROR_TRANSPORT_CATEGORY
-  | typeof TRANSACTION_TRANSPORT_CATEGORY
-  | typeof ATTACHMENT_TRANSPORT_CATEGORY
-  | typeof SESSION_TRANSPORT_CATEGORY;
-
-export type TransportRequest = {
-  body: string;
-  category: TransportCategory;
-};
-
-export type TransportMakeRequestResponse = {
-  body?: string;
-  headers?: {
-    [key: string]: string | null;
-    'x-sentry-rate-limits': string | null;
-    'retry-after': string | null;
-  };
-  reason?: string;
-  statusCode: number;
-};
-
-export type TransportResponse = {
-  status: EventStatus;
-  reason?: string;
-};
-
-interface InternalBaseTransportOptions {
-  bufferSize?: number;
-}
-export interface BaseTransportOptions extends InternalBaseTransportOptions {
-  // url to send the event
-  // transport does not care about dsn specific - client should take care of
-  // parsing and figuring that out
-  url: string;
-}
-
-export interface NewTransport {
-  send(request: Envelope): PromiseLike<TransportResponse>;
-  flush(timeout?: number): PromiseLike<boolean>;
-}
-
-export type TransportRequestExecutor = (request: TransportRequest) => PromiseLike<TransportMakeRequestResponse>;
-
 export const DEFAULT_TRANSPORT_BUFFER_SIZE = 30;
 
 /**

packages/types/src/client.ts

@@ -5,7 +5,7 @@ import { Options } from './options';
 import { Scope } from './scope';
 import { Session } from './session';
 import { Severity, SeverityLevel } from './severity';
-import { Transport } from './transport';
+import { NewTransport } from './transport';
 
 /**
  * User-Facing Sentry SDK Client.
@@ -68,11 +68,10 @@ export interface Client<O extends Options = Options> {
 
   /**
    * Returns the transport that is used by the client.
-   * Please note that the transport gets lazy initialized so it will only be there once the first event has been sent.
    *
    * @returns The transport.
    */
-  getTransport?(): Transport;
+  getTransport(): NewTransport;
 
   /**
    * Flush the event queue and set the client to `enabled = false`. See {@link Client.flush}.

packages/types/src/index.ts

@@ -62,6 +62,19 @@ export type {
   TransactionSamplingMethod,
 } from './transaction';
 export type { Thread } from './thread';
-export type { Outcome, Transport, TransportOptions, TransportClass } from './transport';
+export type {
+  Outcome,
+  Transport,
+  TransportOptions,
+  TransportClass,
+  TransportCategory,
+  TransportRequest,
+  TransportMakeRequestResponse,
+  TransportResponse,
+  InternalBaseTransportOptions,
+  BaseTransportOptions,
+  NewTransport,
+  TransportRequestExecutor,
+} from './transport';
 export type { User, UserFeedback } from './user';
 export type { WrappedFunction } from './wrappedfunction';

packages/types/src/transport.ts

@@ -1,5 +1,7 @@
 import { DsnLike } from './dsn';
+import { Envelope } from './envelope';
 import { Event } from './event';
+import { EventStatus } from './eventstatus';
 import { SentryRequestType } from './request';
 import { Response } from './response';
 import { SdkMetadata } from './sdkmetadata';
@@ -13,6 +15,46 @@ export type Outcome =
   | 'ratelimit_backoff'
   | 'sample_rate';
 
+export type TransportCategory = 'error' | 'transaction' | 'attachment' | 'session';
+
+export type TransportRequest = {
+  body: string;
+  category: TransportCategory;
+};
+
+export type TransportMakeRequestResponse = {
+  body?: string;
+  headers?: {
+    [key: string]: string | null;
+    'x-sentry-rate-limits': string | null;
+    'retry-after': string | null;
+  };
+  reason?: string;
+  statusCode: number;
+};
+
+export type TransportResponse = {
+  status: EventStatus;
+  reason?: string;
+};
+
+export interface InternalBaseTransportOptions {
+  bufferSize?: number;
+}
+export interface BaseTransportOptions extends InternalBaseTransportOptions {
+  // url to send the event
+  // transport does not care about dsn specific - client should take care of
+  // parsing and figuring that out
+  url: string;
+}
+
+export interface NewTransport {
+  send(request: Envelope): PromiseLike<TransportResponse>;
+  flush(timeout?: number): PromiseLike<boolean>;
+}
+
+export type TransportRequestExecutor = (request: TransportRequest) => PromiseLike<TransportMakeRequestResponse>;
+
 /** Transport used sending data to Sentry */
 export interface Transport {
   /**