Skip to content

Commit 6f40561

Browse files
committed
Merge pull request #264 from pkaminski/master
Fix globalOptions overwrite.
2 parents 27d98ca + 965973f commit 6f40561

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/raven.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -656,8 +656,8 @@ function send(data) {
656656
}, data);
657657

658658
// Merge in the tags and extra separately since objectMerge doesn't handle a deep merge
659-
data.tags = objectMerge(globalOptions.tags, data.tags);
660-
data.extra = objectMerge(globalOptions.extra, data.extra);
659+
data.tags = objectMerge(objectMerge({}, globalOptions.tags), data.tags);
660+
data.extra = objectMerge(objectMerge({}, globalOptions.extra), data.extra);
661661

662662
// Send along our own collected metadata with extra
663663
data.extra = objectMerge({

test/raven.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -897,6 +897,11 @@ describe('globals', function() {
897897
tags: {tag1: 'value1', tag2: 'value2'},
898898
extra: {'session:duration': 100}
899899
}]);
900+
assert.deepEqual(globalOptions, {
901+
logger: 'javascript',
902+
site: 'THE BEST',
903+
tags: {tag1: 'value1'}
904+
});
900905
});
901906

902907
it('should merge in global extra', function() {
@@ -930,6 +935,11 @@ describe('globals', function() {
930935
event_id: 'abc123',
931936
extra: {key1: 'value1', key2: 'value2', 'session:duration': 100}
932937
}]);
938+
assert.deepEqual(globalOptions, {
939+
logger: 'javascript',
940+
site: 'THE BEST',
941+
extra: {key1: 'value1'}
942+
});
933943
});
934944

935945
it('should let dataCallback override everything', function() {

0 commit comments

Comments
 (0)