Skip to content

Commit 73a1bbb

Browse files
authored
ci: Avoid continue-on-error for nextjs tests (#7308)
1 parent a6b65c4 commit 73a1bbb

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ jobs:
435435
strategy:
436436
fail-fast: false
437437
matrix:
438-
node: [10, 12, 14, 16, '18.13.0']
438+
node: [10, 12, 14, 16, 18]
439439
steps:
440440
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
441441
uses: actions/checkout@v3
@@ -462,14 +462,12 @@ jobs:
462462
path: ${{ steps.npm-cache-dir.outputs.dir }}
463463
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
464464
- name: Install Playwright browser if not cached
465-
if: steps.playwright-cache.outputs.cache-hit != 'true'
466-
continue-on-error: true # playwright needs node >= 14
465+
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
467466
run: npx playwright install --with-deps
468467
env:
469468
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
470469
- name: Install OS dependencies of Playwright if cache hit
471-
if: steps.playwright-cache.outputs.cache-hit == 'true'
472-
continue-on-error: true # playwright needs node >= 14
470+
if: steps.playwright-cache.outputs.cache-hit == 'true' && matrix.node >= 14
473471
run: npx playwright install-deps
474472
- name: Run tests
475473
env:

0 commit comments

Comments
 (0)