feat(fastify): Update scope transactionName when handling request

Author: Lms24

dev-packages/e2e-tests/test-applications/node-fastify-app/src/app.js

@@ -55,8 +55,8 @@ app.get('/test-error', async function (req, res) {
   res.send({ exceptionId });
 });
 
-app.get('/test-exception', async function (req, res) {
-  throw new Error('This is an exception');
+app.get('/test-exception/:id', async function (req, res) {
+  throw new Error(`This is an exception with id ${req.params.id}`);
 });
 
 app.get('/test-outgoing-fetch-external-allowed', async function (req, res) {

dev-packages/e2e-tests/test-applications/node-fastify-app/tests/errors.test.ts

@@ -41,28 +41,28 @@ test('Sends exception to Sentry', async ({ baseURL }) => {
 
 test('Sends correct error event', async ({ baseURL }) => {
   const errorEventPromise = waitForError('node-fastify-app', event => {
-    return !event.type && event.exception?.values?.[0]?.value === 'This is an exception';
+    return !event.type && event.exception?.values?.[0]?.value === 'This is an exception with id 123';
   });
 
   try {
-    await axios.get(`${baseURL}/test-exception`);
+    await axios.get(`${baseURL}/test-exception/123`);
   } catch {
     // this results in an error, but we don't care - we want to check the error event
   }
 
   const errorEvent = await errorEventPromise;
 
   expect(errorEvent.exception?.values).toHaveLength(1);
-  expect(errorEvent.exception?.values?.[0]?.value).toBe('This is an exception');
+  expect(errorEvent.exception?.values?.[0]?.value).toBe('This is an exception with id 123');
 
   expect(errorEvent.request).toEqual({
     method: 'GET',
     cookies: {},
     headers: expect.any(Object),
-    url: 'http://localhost:3030/test-exception',
+    url: 'http://localhost:3030/test-exception/123',
   });
 
-  expect(errorEvent.transaction).toEqual('GET /test-exception');
+  expect(errorEvent.transaction).toEqual('GET /test-exception/:id');
 
   expect(errorEvent.contexts?.trace).toEqual({
     trace_id: expect.any(String),

packages/node/src/integrations/tracing/fastify.ts

@@ -1,8 +1,10 @@
 import { registerInstrumentations } from '@opentelemetry/instrumentation';
+import type { FastifyRequestInfo } from '@opentelemetry/instrumentation-fastify';
 import { FastifyInstrumentation } from '@opentelemetry/instrumentation-fastify';
-import { captureException, defineIntegration } from '@sentry/core';
+import { captureException, defineIntegration, getIsolationScope, spanToJSON } from '@sentry/core';
 import type { IntegrationFn } from '@sentry/types';
 
+import type { Span } from '@opentelemetry/api';
 import { addOriginToSpan } from '../../utils/addOriginToSpan';
 
 const _fastifyIntegration = (() => {
@@ -12,8 +14,9 @@ const _fastifyIntegration = (() => {
       registerInstrumentations({
         instrumentations: [
           new FastifyInstrumentation({
-            requestHook(span) {
+            requestHook(span, info) {
               addOriginToSpan(span, 'auto.http.otel.fastify');
+              updateScopeTransactionName(span, info);
             },
           }),
         ],
@@ -22,6 +25,22 @@ const _fastifyIntegration = (() => {
   };
 }) satisfies IntegrationFn;
 
+function updateScopeTransactionName(span: Span, info: FastifyRequestInfo): void {
+  if (!span.isRecording()) {
+    return;
+  }
+
+  const attributes = spanToJSON(span).data;
+  if (!attributes || !attributes['http.route']) {
+    return;
+  }
+
+  const req = info.request as { method?: string };
+  const method = req.method?.toUpperCase() || 'GET';
+  const route = String(attributes['http.route']);
+  getIsolationScope().setTransactionName(`${method} ${route}`);
+}
+
 /**
  * Express integration
  *