Merge branch 'develop' into nh/nestjs-middleware-instrumentation

Author: nicohrubec

.github/ISSUE_TEMPLATE/bug.yml

@@ -80,11 +80,14 @@ body:
   - type: textarea
     id: sdk-setup
     attributes:
-      label: SDK Setup/Reproduction Example
+      label: Reproduction Example/SDK Setup
       description:
-        How do you set up your Sentry SDK? Please show us your `Sentry.init` code.
-        Or even better—share a link to a reproduction example.
+        To ensure that we can help you as fast as possible, please share a link to a reproduction example (GitHub repo or online code editor).
+        This enables us to quickly understand and address your issue.
+        If you do not post a link, kindly paste your `Sentry.init` code, so we can see how you set up Sentry.
       placeholder: |-
+        https://some-JS-online-code-editor.com/my-example
+
         ```javascript
         Sentry.init({
           dsn: __YOUR_DSN__

.github/workflows/build.yml

@@ -519,7 +519,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18, 20, 22.4]
+        node: [14, 16, 18, 20, 22]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -579,7 +579,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18, 20, 22.4]
+        node: [14, 16, 18, 20, 22]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -816,12 +816,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18, 20, 22.4]
+        node: [14, 16, 18, 20, 22]
         typescript:
           - false
         include:
           # Only check typescript for latest version (to streamline CI)
-          - node: 22.4
+          - node: 22
             typescript: '3.8'
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
@@ -858,7 +858,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [18, 20, 22.4]
+        node: [18, 20, 22]
         remix: [1, 2]
         # Remix v2 only supports Node 18+, so run 16 tests separately
         include:
@@ -990,6 +990,7 @@ jobs:
             'node-express-esm-without-loader',
             'node-express-cjs-preload',
             'node-otel-sdk-node',
+            'node-otel-custom-sampler',
             'ember-classic',
             'ember-embroider',
             'nextjs-app-dir',
@@ -1384,7 +1385,7 @@ jobs:
           - os: ubuntu-20.04
             node: 20
           - os: ubuntu-20.04
-            node: 22.4
+            node: 22
 
             # x64 musl
           - os: ubuntu-20.04
@@ -1398,7 +1399,7 @@ jobs:
             node: 20
           - os: ubuntu-20.04
             container: node:22-alpine3.18
-            node: 22.4
+            node: 22
 
             # arm64 glibc
           - os: ubuntu-20.04
@@ -1412,7 +1413,7 @@ jobs:
             node: 20
           - os: ubuntu-20.04
             arch: arm64
-            node: 22.4
+            node: 22
 
             # arm64 musl
           - os: ubuntu-20.04
@@ -1430,7 +1431,7 @@ jobs:
           - os: ubuntu-20.04
             arch: arm64
             container: node:22-alpine3.18
-            node: 22.4
+            node: 22
 
             # macos x64
           - os: macos-13
@@ -1443,7 +1444,7 @@ jobs:
             node: 20
             arch: x64
           - os: macos-13
-            node: 22.4
+            node: 22
             arch: x64
 
             # macos arm64
@@ -1461,7 +1462,7 @@ jobs:
             target_platform: darwin
           - os: macos-13
             arch: arm64
-            node: 22.4
+            node: 22
             target_platform: darwin
 
             # windows x64
@@ -1475,7 +1476,7 @@ jobs:
             node: 20
             arch: x64
           - os: windows-2022
-            node: 22.4
+            node: 22
             arch: x64
 
     steps:

CHANGELOG.md

@@ -8,6 +8,29 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 8.20.0
+
+### Important Changes
+
+- **feat(node): Allow to pass `registerEsmLoaderHooks` to preload (#12998)**
+
+You can write your own custom preload script and configure this in the preload options. `registerEsmLoaderHooks` can be
+passed as an option to `preloadOpenTelemetry`, which allows to exclude/include packages in the preload.
+
+- **fix(node): Do not emit fetch spans when tracing is disabled (#13003)**
+
+Sentry will not emit "fetch" spans if tracing is disabled. This is relevant for user who use their own sampler.
+
+### Other Changes
+
+- feat(feedback): Trigger button aria label configuration (#13008)
+- feat(nestjs): Change nest sdk setup (#12920)
+- feat(node): Extend ESM hooks options for iitm v1.10.0 (#13016)
+- feat(node): Send client reports (#12951)
+- feat(nuxt): Automatically add BrowserTracing (#13005)
+- feat(nuxt): Setup source maps with vite config (#13018)
+- feat(replay): Improve public Replay APIs (#13000)
+
 ## 8.19.0
 
 - feat(core): Align Span interface with OTEL (#12898)

dev-packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "8.19.0",
+  "version": "8.20.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -43,7 +43,7 @@
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "^1.44.1",
     "@sentry-internal/rrweb": "2.11.0",
-    "@sentry/browser": "8.19.0",
+    "@sentry/browser": "8.20.0",
     "axios": "1.6.7",
     "babel-loader": "^8.2.2",
     "html-webpack-plugin": "^5.5.0",

dev-packages/bundle-analyzer-scenarios/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/bundle-analyzer-scenarios",
-  "version": "8.19.0",
+  "version": "8.20.0",
   "description": "Scenarios to test bundle analysis with",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",

dev-packages/e2e-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/e2e-tests",
-  "version": "8.19.0",
+  "version": "8.20.0",
   "license": "MIT",
   "private": true,
   "scripts": {

dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-express-legacy', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('routes/user.$id');
+});
+
 test('Sends form data with action span to Sentry', async ({ page }) => {
   await page.goto('/action-formdata');
 

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-express-vite-dev', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('GET user/:id');
+});
+
 test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
   // We use this to identify the transactions
   const testTag = uuid4();

dev-packages/e2e-tests/test-applications/create-remix-app-express/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-express', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('GET user/:id');
+});
+
 test('Sends form data with action span', async ({ page }) => {
   await page.goto('/action-formdata');
 

dev-packages/e2e-tests/test-applications/create-remix-app-legacy/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-legacy', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('routes/user.$id');
+});
+
 test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
   // We use this to identify the transactions
   const testTag = uuid4();

dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-v2-legacy', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('routes/user.$id');
+});
+
 test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
   // We use this to identify the transactions
   const testTag = uuid4();

dev-packages/e2e-tests/test-applications/create-remix-app-v2/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app-v2', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('GET user/:id');
+});
+
 test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
   // We use this to identify the transactions
   const testTag = uuid4();

dev-packages/e2e-tests/test-applications/create-remix-app/tests/server-transactions.test.ts

@@ -3,6 +3,21 @@ import { uuid4 } from '@sentry/utils';
 
 import { waitForTransaction } from '@sentry-internal/test-utils';
 
+test.describe.configure({ mode: 'serial' });
+
+test('Sends parameterized transaction name to Sentry', async ({ page }) => {
+  const transactionPromise = waitForTransaction('create-remix-app', transactionEvent => {
+    return transactionEvent.contexts?.trace?.op === 'http.server';
+  });
+
+  await page.goto('/user/123');
+
+  const transaction = await transactionPromise;
+
+  expect(transaction).toBeDefined();
+  expect(transaction.transaction).toBe('GET user/:id');
+});
+
 test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
   // We use this to identify the transactions
   const testTag = uuid4();

dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/.gitignore

@@ -0,0 +1,2 @@
+dist
+.vscode

dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/.npmrc

@@ -0,0 +1,2 @@
+@sentry:registry=http://127.0.0.1:4873
+@sentry-internal:registry=http://127.0.0.1:4873

dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/package.json

@@ -0,0 +1,31 @@
+{
+  "name": "node-otel-custom-sampler",
+  "version": "1.0.0",
+  "private": true,
+  "scripts": {
+    "build": "tsc",
+    "start": "node dist/app.js",
+    "test": "playwright test",
+    "clean": "npx rimraf node_modules pnpm-lock.yaml",
+    "test:build": "pnpm install && pnpm build",
+    "test:assert": "pnpm test"
+  },
+  "dependencies": {
+    "@opentelemetry/api": "^1.9.0",
+    "@opentelemetry/sdk-trace-node": "^1.25.1",
+    "@sentry/node": "latest || *",
+    "@sentry/opentelemetry": "latest || *",
+    "@sentry/types": "latest || *",
+    "@types/express": "4.17.17",
+    "@types/node": "18.15.1",
+    "express": "4.19.2",
+    "typescript": "4.9.5"
+  },
+  "devDependencies": {
+    "@playwright/test": "^1.44.1",
+    "@sentry-internal/test-utils": "link:../../../test-utils"
+  },
+  "volta": {
+    "extends": "../../package.json"
+  }
+}

dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/playwright.config.mjs

@@ -0,0 +1,7 @@
+import { getPlaywrightConfig } from '@sentry-internal/test-utils';
+
+const config = getPlaywrightConfig({
+  startCommand: `pnpm start`,
+});
+
+export default config;