Skip to content

Commit 74c9bd5

Browse files
committed
chore: fix linting
1 parent f42b945 commit 74c9bd5

File tree

4 files changed

+24
-22
lines changed

4 files changed

+24
-22
lines changed

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/resource-spans-ignored/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Sentry.init({
66
dsn: 'https://[email protected]/1337',
77
integrations: [
88
Sentry.browserTracingIntegration({
9-
ignoreResourceSpans: ['resource.script']
9+
ignoreResourceSpans: ['resource.script'],
1010
}),
1111
],
1212
tracesSampleRate: 1,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/resource-spans-ignored/test.ts

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,13 @@ import type { Event } from '@sentry/core';
44
import { sentryTest } from '../../../../utils/fixtures';
55
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
66

7-
sentryTest(
8-
'should allow specific types of resource spans to be ignored.',
9-
async ({ getLocalTestUrl, page }) => {
10-
await page.route('**/path/to/script.js', (route: Route) =>
11-
route.fulfill({ path: `${__dirname}/assets/script.js` }),
12-
);
7+
sentryTest('should allow specific types of resource spans to be ignored.', async ({ getLocalTestUrl, page }) => {
8+
await page.route('**/path/to/script.js', (route: Route) => route.fulfill({ path: `${__dirname}/assets/script.js` }));
139

14-
const url = await getLocalTestUrl({ testDir: __dirname });
10+
const url = await getLocalTestUrl({ testDir: __dirname });
1511

16-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
17-
const uiSpans = eventData.spans?.filter(({ op }) => op?.startsWith('resource.script'));
12+
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
13+
const uiSpans = eventData.spans?.filter(({ op }) => op?.startsWith('resource.script'));
1814

19-
expect(uiSpans?.length).toBe(0);
20-
},
21-
);
15+
expect(uiSpans?.length).toBe(0);
16+
});

packages/browser-utils/src/metrics/browserMetrics.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,15 @@ export function addPerformanceEntries(span: Span, options: AddPerformanceEntries
362362
break;
363363
}
364364
case 'resource': {
365-
_addResourceSpans(span, entry as PerformanceResourceTiming, entry.name, startTime, duration, timeOrigin, options.ignoreResourceSpans);
365+
_addResourceSpans(
366+
span,
367+
entry as PerformanceResourceTiming,
368+
entry.name,
369+
startTime,
370+
duration,
371+
timeOrigin,
372+
options.ignoreResourceSpans,
373+
);
366374
break;
367375
}
368376
// Ignore other entry types.
@@ -575,7 +583,7 @@ export function _addResourceSpans(
575583
startTime: number,
576584
duration: number,
577585
timeOrigin: number,
578-
ignoreResourceSpans?: Array<string>
586+
ignoreResourceSpans?: Array<string>,
579587
): void {
580588
// we already instrument based on fetch and xhr, so we don't need to
581589
// duplicate spans here.

packages/browser-utils/test/browser/browserMetrics.test.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -273,10 +273,7 @@ describe('_addResourceSpans', () => {
273273

274274
it('allows resource spans to be ignored via ignoreResourceSpans', () => {
275275
const spans: Span[] = [];
276-
const ignoredResourceSpans = [
277-
'resource.other',
278-
'resource.script'
279-
];
276+
const ignoredResourceSpans = ['resource.other', 'resource.script'];
280277

281278
getClient()?.on('spanEnd', span => {
282279
spans.push(span);
@@ -313,9 +310,11 @@ describe('_addResourceSpans', () => {
313310
_addResourceSpans(span, entry, 'https://example.com/assets/to/me', 123, 234, 465, ignoredResourceSpans);
314311
}
315312
expect(spans).toHaveLength(table.length - ignoredResourceSpans.length);
316-
const spanOps = new Set(spans.map((s) => {
317-
return spanToJSON(s).op;
318-
}));
313+
const spanOps = new Set(
314+
spans.map(s => {
315+
return spanToJSON(s).op;
316+
}),
317+
);
319318
expect(spanOps).toEqual(new Set(['resource.css', 'resource.image']));
320319
});
321320

0 commit comments

Comments
 (0)